kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Markus Elfring <Markus.Elfring@web.de>,
	linux-doc@vger.kernel.org, Coccinelle <cocci@systeme.lip6.fr>
Cc: Michal Marek <michal.lkml@markovi.net>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	kernel-janitors@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	LKML <linux-kernel@vger.kernel.org>,
	Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH v2] Documentation: Coccinelle: fix typos and command example
Date: Tue, 30 Jun 2020 15:11:18 +0000	[thread overview]
Message-ID: <efc8b0c9-db3b-3c9c-d876-897b53a9e278@infradead.org> (raw)
In-Reply-To: <c2c1dec0-2bd1-b0e2-1aa4-38d0e954d5ba@web.de>

On 6/30/20 5:23 AM, Markus Elfring wrote:
> …
>> +++ linux-next-20200629/Documentation/dev-tools/coccinelle.rst
> …> @@ -177,13 +177,13 @@ For example, to check drivers/net/wirele
>>  To apply Coccinelle on a file basis, instead of a directory basis, the
>>  following command may be used::
>>
>> -    make C=1 CHECK="scripts/coccicheck"
>> +    make C=1 CHECK="scripts/coccicheck" path/to/file.c
> 
> I would like to clarify further software design aspects around such make functionality.
> 
> We might stumble on different interpretations according to the wording “file basis”.
> Do you find a message like “make: Nothing to be done for 'path/to/file.c'.” interesting then?
> 
> * Would you like to add any links for information around the support for
>   source code checkers?
>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Makefile?id|30b859a947535f2213277e827d7ac7dcff9c84#n198
> 
> * How do you think about to enclose the path for the shown parameter
>   by single quotes instead of double quotes?
> 
> * Can such path specifications become more interesting occasionally
>   if also an other file extension would be chosen than “.c”?
>   Would you like to achieve any software extensions around suffix rules?
> 
> Regards,
> Markus

Markus:

Feel free to submit patches.

-- 
~Randy

  reply	other threads:[~2020-06-30 15:11 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0616dd0c-bb86-be2b-3dc6-1c695a92c3ca@infradead.org>
2020-06-30  8:04 ` [PATCH v2] Documentation: Coccinelle: fix typos and command example Markus Elfring
2020-06-30 12:23 ` Markus Elfring
2020-06-30 15:11   ` Randy Dunlap [this message]
2020-07-01 11:56     ` Markus Elfring
2020-07-01 13:20       ` Randy Dunlap
2020-07-01 13:32         ` [v2] " Markus Elfring
2020-07-01 14:52           ` Randy Dunlap
2020-07-01 15:02             ` Markus Elfring
2020-07-01 15:07               ` Randy Dunlap
2020-07-01 15:15                 ` Markus Elfring
2020-07-01 15:19                   ` Jonathan Corbet
2020-07-01 15:23                     ` Markus Elfring
2020-07-01 15:15                 ` Markus Elfring
2020-07-01 15:19                   ` Randy Dunlap
2020-07-01 15:32                     ` Markus Elfring
2020-07-01 17:32                     ` Markus Elfring
2020-07-01 19:15                       ` Randy Dunlap
2020-07-01 20:10                         ` Markus Elfring
     [not found]                           ` <alpine.DEB.2.22.394.2007012232510.2540@hadrien>
2020-07-02  6:01                             ` Markus Elfring
2020-07-02  8:22                             ` Markus Elfring
2020-07-02  0:08             ` Matthew Wilcox
2020-07-02  5:40               ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=efc8b0c9-db3b-3c9c-d876-897b53a9e278@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=Gilles.Muller@lip6.fr \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=corbet@lwn.net \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).