From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Date: Wed, 01 Jul 2020 13:20:34 +0000 Subject: Re: [PATCH v2] Documentation: Coccinelle: fix typos and command example Message-Id: List-Id: References: <0616dd0c-bb86-be2b-3dc6-1c695a92c3ca@infradead.org> <2a3940de-6a81-1aff-8109-53c1c5a6aa1b@web.de> In-Reply-To: <2a3940de-6a81-1aff-8109-53c1c5a6aa1b@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Markus Elfring , linux-doc@vger.kernel.org, Coccinelle Cc: Michal Marek , Gilles Muller , kernel-janitors@vger.kernel.org, Jonathan Corbet , Nicolas Palix , LKML , Julia Lawall On 7/1/20 4:56 AM, Markus Elfring wrote: >>> … >>>> +++ linux-next-20200629/Documentation/dev-tools/coccinelle.rst >>> … >>>> @@ -177,13 +177,13 @@ For example, to check drivers/net/wirele >>>> To apply Coccinelle on a file basis, instead of a directory basis, the >>>> following command may be used:: >>>> >>>> - make C=1 CHECK="scripts/coccicheck" >>>> + make C=1 CHECK="scripts/coccicheck" path/to/file.c > … >>> We might stumble on different interpretations according to the wording “file basis”. >>> Do you find a message like “make: Nothing to be done for 'path/to/file.c'.” interesting then? >>> >>> * Would you like to add any links for information around the support for >>> source code checkers? >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Makefile?id|30b859a947535f2213277e827d7ac7dcff9c84#n198 > … >> Feel free to submit patches. > > How do you think about to use the following command variant > for the adjustment of the software documentation? > > + make C=1 CHECK='scripts/coccicheck' 'path/to/file.o' > I don't understand the reason for that change... -- ~Randy