From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Sat, 03 Oct 2020 18:40:48 +0000 Subject: Re: [PATCH 00/18] use semicolons rather than commas to separate statements Message-Id: List-Id: References: <1601233948-11629-1-git-send-email-Julia.Lawall@inria.fr> <160132172369.55460.9237357219623604216.b4-ty@kernel.org> <20200929113745.GB4799@sirena.org.uk> <20201001110150.GA6715@sirena.org.uk> In-Reply-To: <20201001110150.GA6715@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mark Brown , tools@linux.kernel.org, Konstantin Ryabitsev Cc: linux-iio@vger.kernel.org, Julia Lawall , linux-stm32@st-md-mailman.stormreply.com, linux-crypto@vger.kernel.org, "Rafael J. Wysocki" , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Brunet , linux-acpi@vger.kernel.org, David Lechner , Valdis =?UTF-8?Q?Kl=C4=93tnieks?= , kernel-janitors@vger.kernel.org, drbd-dev@lists.linbit.com, openipmi-developer@lists.sourceforge.net, Martin Blumenstingl , linux-ide@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Gleixner , linux-wireless@vger.kernel.org, Neil Armstrong (Adding tools and Konstantin Ryabitsev) There seems to be some mismatch between b4's use of the cover letter to a patch series and what maintainers that apply a subset of the patches in the patch series. The merge description shows the entire patch series as applied, but the actual merge is only a subset of the series. Can this be improved in b4? For example, regarding: https://lore.kernel.org/linux-amlogic/160132172369.55460.9237357219623604216.b4-ty@kernel.org/ https://lore.kernel.org/lkml/b1174f9be2ce65f6b5ebefcba0b48e792926abbc.camel@perches.com/#t On Thu, 2020-10-01 at 12:01 +0100, Mark Brown wrote: > On Wed, Sep 30, 2020 at 12:33:39PM -0700, Joe Perches wrote: > > On Tue, 2020-09-29 at 12:37 +0100, Mark Brown wrote: > > > Feel free to submit patches to b4. > > Have you tried the existing option to send > > thank you's on a specific ranges of patches? > > I am relying on b4 to identify which patches that I've downloaded are in > the pushed branches. Given that it explicitly lists the patches that > are applied it appears to be doing an OK job here. I'm not so sure about that. The commit merge description in -next shows 23 files modified but the commit range shown in the merge shows only a single patch applied: >From next-20201002: (I've removed some of the commit description below) $ git log --stat -1 2defc3fa18a68963a330187f5386968e50832d06 commit 2defc3fa18a68963a330187f5386968e50832d06 Merge: eb45df24fe82 7f4a122d0b50 Author: Mark Brown Date: Mon Sep 28 18:28:48 2020 +0100 Merge series "use semicolons rather than commas to separate statements" from Julia Lawall : These patches replace commas by semicolons. This was done using the Coccinelle semantic patch (http://coccinelle.lip6.fr/) shown below. [some of the long description elided] --- drivers/acpi/processor_idle.c | 4 +++- drivers/ata/pata_icside.c | 21 +++++++++++++-------- drivers/base/regmap/regmap-debugfs.c | 2 +- drivers/bcma/driver_pci_host.c | 4 ++-- drivers/block/drbd/drbd_receiver.c | 6 ++++-- drivers/char/agp/amd-k7-agp.c | 2 +- drivers/char/agp/nvidia-agp.c | 2 +- drivers/char/agp/sworks-agp.c | 2 +- drivers/char/hw_random/iproc-rng200.c | 8 ++++---- drivers/char/hw_random/mxc-rnga.c | 6 +++--- drivers/char/hw_random/stm32-rng.c | 8 ++++---- drivers/char/ipmi/bt-bmc.c | 6 +++--- drivers/clk/meson/meson-aoclk.c | 2 +- drivers/clk/mvebu/ap-cpu-clk.c | 2 +- drivers/clk/uniphier/clk-uniphier-cpugear.c | 2 +- drivers/clk/uniphier/clk-uniphier-mux.c | 2 +- drivers/clocksource/mps2-timer.c | 6 +++--- drivers/clocksource/timer-armada-370-xp.c | 8 ++++---- drivers/counter/ti-eqep.c | 2 +- drivers/crypto/amcc/crypto4xx_alg.c | 2 +- drivers/crypto/atmel-tdes.c | 2 +- drivers/crypto/hifn_795x.c | 4 ++-- drivers/crypto/talitos.c | 8 ++++---- 23 files changed, 60 insertions(+), 51 deletions(-) But the commit range of the merge shows only the single commit: $ git log --stat eb45df24fe82..7f4a122d0b50 commit 7f4a122d0b50b40c64d24a5cf7aafe26dd9487ee Author: Julia Lawall Date: Sun Sep 27 21:12:24 2020 +0200 regmap: debugfs: use semicolons rather than commas to separate statements Replace commas with semicolons. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @@ expression e1,e2; @@ e1 -, +; e2 ... when any // Signed-off-by: Julia Lawall Link: https://lore.kernel.org/r/1601233948-11629-15-git-send-email-Julia.La> Signed-off-by: Mark Brown drivers/base/regmap/regmap-debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)