From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Elfring Date: Wed, 12 Jun 2019 06:24:12 +0000 Subject: Re: Coccinelle: api: add devm_platform_ioremap_resource script Message-Id: List-Id: References: <20190406061112.31620-1-himanshujha199640@gmail.com> <7b4fe770-dadd-80ba-2ba4-0f2bc90984ef@web.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Enrico Weigelt Cc: Nicolas Palix , Michal Marek , Bartosz Golaszewski , Greg Kroah-Hartman , Linus Walleij , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , cocci@systeme.lip6.fr >> The flag “IORESOURCE_MEM” is passed as the second parameter for the call >> of the function “platform_get_resource” in this refactoring. > > In that particular case, we maybe should consider separate inline > helpers instead of passing this is a parameter. > > Maybe it would even be more efficient to have completely separate > versions of devm_platform_ioremap_resource(), so we don't even have > to pass that parameter on stack. Would you like to add another function which should be called instead of the combination of the functions “platform_get_resource” and “devm_ioremap_resource”? Regards, Markus