From: "libaokun (A)" <libaokun1@huawei.com>
To: <dsterba@suse.cz>, Anand Jain <anand.jain@oracle.com>,
<linux-kernel@vger.kernel.org>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, <weiyongjun1@huawei.com>,
<yuehaibing@huawei.com>, <yangjihong1@huawei.com>,
<yukuai3@huawei.com>, <linux-btrfs@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] btrfs: send: use list_move_tail instead of list_del/list_add_tail
Date: Fri, 11 Jun 2021 14:05:53 +0800 [thread overview]
Message-ID: <f7bea721-cda5-0b20-13e3-28c4bd728063@huawei.com> (raw)
In-Reply-To: <20210608141233.GQ31483@twin.jikos.cz>
Thank you for your advice.
I'm about to send a patch v2 with the changes suggested by you.
Best Regards
在 2021/6/8 22:12, David Sterba 写道:
> On Tue, Jun 08, 2021 at 01:16:21PM +0800, Anand Jain wrote:
>> On 8/6/21 11:12 am, Baokun Li wrote:
>>> Using list_move_tail() instead of list_del() + list_add_tail().
>>>
>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>> Signed-off-by: Baokun Li <libaokun1@huawei.com>
>>> ---
>>> fs/btrfs/send.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
>>> index bd69db72acc5..a0e51b2416a1 100644
>>> --- a/fs/btrfs/send.c
>>> +++ b/fs/btrfs/send.c
>>> @@ -2083,8 +2083,7 @@ static struct name_cache_entry *name_cache_search(struct send_ctx *sctx,
>>> */
>>> static void name_cache_used(struct send_ctx *sctx, struct name_cache_entry *nce)
>>> {
>>> - list_del(&nce->list);
>>> - list_add_tail(&nce->list, &sctx->name_cache_list);
>>> + list_move_tail(&nce->list, &sctx->name_cache_list);
>>> }
>>
>> Looks good.
>> You can consider open-code name_cache_used() as there is only one user.
> Yeah sounds like a good idea, with part of the function comment next to
> the list_move_tail.
> .
prev parent reply other threads:[~2021-06-11 6:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 3:12 [PATCH -next] btrfs: send: use list_move_tail instead of list_del/list_add_tail Baokun Li
2021-06-08 5:16 ` Anand Jain
2021-06-08 14:12 ` David Sterba
2021-06-11 6:05 ` libaokun (A) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7bea721-cda5-0b20-13e3-28c4bd728063@huawei.com \
--to=libaokun1@huawei.com \
--cc=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=hulkci@huawei.com \
--cc=josef@toxicpanda.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=yangjihong1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).