From: Colin Ian King <colin.king@canonical.com>
To: Jiri Kosina <jikos@kernel.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
linux-input@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: NAK: [PATCH] HID: thrustmaster: Initialized pointer twi with NULL rather than 0
Date: Sat, 25 Sep 2021 23:26:21 +0100 [thread overview]
Message-ID: <f8e8c609-ac7f-2b6a-b8bf-57a53fadfa1d@canonical.com> (raw)
In-Reply-To: <20210925222216.182099-1-colin.king@canonical.com>
On 25/09/2021 23:22, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointers should be initialized with NULL rather than 0. Fix this.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/hid/hid-thrustmaster.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c
> index d44550aa8805..aa874f075bf9 100644
> --- a/drivers/hid/hid-thrustmaster.c
> +++ b/drivers/hid/hid-thrustmaster.c
> @@ -205,7 +205,7 @@ static void thrustmaster_model_handler(struct urb *urb)
> struct tm_wheel *tm_wheel = hid_get_drvdata(hdev);
> uint16_t model = 0;
> int i, ret;
> - const struct tm_wheel_info *twi = 0;
> + const struct tm_wheel_info *twi = NULL;
>
> if (urb->status) {
> hid_err(hdev, "URB to get model id failed with error %d\n", urb->status);
>
NACK, I spotted another pointer than needs the same change, will send a V2.
prev parent reply other threads:[~2021-09-25 22:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 22:22 [PATCH] HID: thrustmaster: Initialized pointer twi with NULL rather than 0 Colin King
2021-09-25 22:26 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8e8c609-ac7f-2b6a-b8bf-57a53fadfa1d@canonical.com \
--to=colin.king@canonical.com \
--cc=alexandre.torgue@foss.st.com \
--cc=jikos@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).