From: Jiri Kosina <jikos@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Stefan Achatz <erazor_de@users.sourceforge.net>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] HID: roccat: add bounds checking in kone_sysfs_write_settings()
Date: Mon, 17 Aug 2020 10:07:10 +0000 [thread overview]
Message-ID: <nycvar.YFH.7.76.2008171206280.27422@cbobk.fhfr.pm> (raw)
In-Reply-To: <20200805095501.GD483832@mwanda>
On Wed, 5 Aug 2020, Dan Carpenter wrote:
> In the original code we didn't check if the new value for
> "settings->startup_profile" was within bounds that could possibly
> result in an out of bounds array acccess. What we did was we checked if
> we could write the data to the firmware and it's possibly the firmware
> checks these values but there is no way to know. It's safer and easier
> to read if we check it in the kernel as well.
>
> I also added a check to ensure that "settings->size" was correct. The
> comments say that the only valid value is 36 which is sizeof(struct
> kone_settings).
>
> Fixes: 14bf62cde794 ("HID: add driver for Roccat Kone gaming mouse")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Stefan, could I please get your Reviewed-by and/or Tested-by, to make sure
this doesn't unintentionally somehow break userspace?
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2020-08-17 10:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 9:55 [PATCH] HID: roccat: add bounds checking in kone_sysfs_write_settings() Dan Carpenter
2020-08-17 10:07 ` Jiri Kosina [this message]
2020-08-19 6:53 ` Stefan Achatz
2020-08-24 8:57 ` [PATCH v2] " Dan Carpenter
2020-08-24 15:35 ` AW: " Walter Harms
2020-08-25 7:29 ` Dan Carpenter
2020-08-25 13:08 ` AW: " Walter Harms
2020-09-09 6:35 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2008171206280.27422@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=erazor_de@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).