From: Jiri Kosina <jikos@kernel.org>
To: Bixuan Cui <cuibixuan@huawei.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] HID: gt683r: add missing MODULE_DEVICE_TABLE
Date: Wed, 26 May 2021 12:43:45 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2105261243400.28378@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210508031448.53445-1-cuibixuan@huawei.com>
On Sat, 8 May 2021, Bixuan Cui wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
> ---
> drivers/hid/hid-gt683r.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-gt683r.c b/drivers/hid/hid-gt683r.c
> index 898871c8c768..29ccb0accfba 100644
> --- a/drivers/hid/hid-gt683r.c
> +++ b/drivers/hid/hid-gt683r.c
> @@ -54,6 +54,7 @@ static const struct hid_device_id gt683r_led_id[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL) },
> { }
> };
> +MODULE_DEVICE_TABLE(hid, gt683r_led_id);
>
> static void gt683r_brightness_set(struct led_classdev *led_cdev,
Applied, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-05-26 10:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 3:14 [PATCH -next] HID: gt683r: add missing MODULE_DEVICE_TABLE Bixuan Cui
2021-05-26 10:43 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2105261243400.28378@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=cuibixuan@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).