From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Date: Sun, 04 Jan 2015 14:22:42 +0000 Subject: Re: [PATCH 0/13] ALSA: Deletion of some unnecessary checks Message-Id: List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54A9355F.4050102@users.sourceforge.net> In-Reply-To: <54A9355F.4050102@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: Mark Brown , Jaroslav Kysela , alsa-devel@alsa-project.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall At Sun, 04 Jan 2015 13:43:11 +0100, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Sun, 4 Jan 2015 11:50:12 +0100 > > Further update suggestions were taken into account after several patches > were applied from static source code analysis. > > Markus Elfring (3): > seq: Deletion of unnecessary checks before the function call "snd_midi_event_free" > oss: Deletion of unnecessary checks before the function call "vfree" > emu10k1: Delete an unnecessary check before the function call "kfree" > oxygen: Delete an unnecessary check before the function call "snd_pcm_suspend" > emux: Delete an unnecessary check before the function call "snd_sf_free" > ASoC: Intel: Delete an unnecessary check before the function call "sst_dma_free" > ASoC: fsi: Deletion of unnecessary checks before the function call "clk_enable" > ASoC: Intel: Delete an unnecessary check before the function call "release_firmware" > i2sbus: Delete an unnecessary check before the function call "snd_pcm_suspend_all" > sb: Delete an unnecessary check before the function call "snd_emux_free" > Deletion of checks before the function call "iounmap" > msnd: One function call less in snd_msnd_attach() after error detection > msnd: Fix centralized exiting from snd_msnd_attach() I applied most of them now but leave patches 6-8 left to Mark applying through his tree. As posted in another mail patches 12 and 13 are dropped. BTW, when you sending a new patch series, you should drop the old references tags. thanks, Takashi > > sound/aoa/soundbus/i2sbus/core.c | 13 ++++++------- > sound/arm/aaci.c | 4 ++-- > sound/drivers/ml403-ac97cr.c | 3 +-- > sound/isa/msnd/msnd_pinnacle.c | 31 ++++++++++++++++--------------- > sound/parisc/harmony.c | 4 +--- > sound/pci/ad1889.c | 5 +---- > sound/pci/asihpi/hpioctl.c | 6 ++---- > sound/pci/atiixp.c | 3 +-- > sound/pci/atiixp_modem.c | 3 +-- > sound/pci/aw2/aw2-alsa.c | 4 +--- > sound/pci/bt87x.c | 3 +-- > sound/pci/cs4281.c | 6 ++---- > sound/pci/cs46xx/cs46xx_lib.c | 4 ++-- > sound/pci/ctxfi/cthw20k1.c | 5 +---- > sound/pci/ctxfi/cthw20k2.c | 5 +---- > sound/pci/echoaudio/echoaudio.c | 6 +----- > sound/pci/hda/hda_intel.c | 3 +-- > sound/pci/lola/lola.c | 6 ++---- > sound/pci/mixart/mixart.c | 7 +++---- > sound/pci/nm256/nm256.c | 6 ++---- > sound/pci/rme9652/hdsp.c | 4 +--- > sound/pci/rme9652/hdspm.c | 4 +--- > sound/pci/rme9652/rme9652.c | 3 +-- > sound/pci/sis7019.c | 5 +---- > sound/pci/ymfpci/ymfpci_main.c | 3 +-- > sound/ppc/pmac.c | 15 +++++---------- > 26 files changed, 58 insertions(+), 103 deletions(-) > > -- > 2.2.1 >