From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BDD5C07E9B for ; Tue, 20 Jul 2021 15:58:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 519A6611CE for ; Tue, 20 Jul 2021 15:58:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239771AbhGTPRt (ORCPT ); Tue, 20 Jul 2021 11:17:49 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:57420 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242160AbhGTO7s (ORCPT ); Tue, 20 Jul 2021 10:59:48 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 8978722453; Tue, 20 Jul 2021 15:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626795622; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PxdJRybXj0b5kor3cTcrTlW6O+XJ2p80wJ3iq0K7/j8=; b=A5Wq15YU8vSgD4IWRe1+oClfodgFa8siOLcT4FZxf0P/y/jS+Y/f2XmA3eWxh54vKA4TT0 aCeZZU4KOk1M/N1r9XgdJDEmg0cpw66asaLBUsx2kCiNT1hZlznVIBe4Ld4RUrGNcjZmyP ef1X4RLiYNIETZn8IbZmqf7af+23Qow= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626795622; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PxdJRybXj0b5kor3cTcrTlW6O+XJ2p80wJ3iq0K7/j8=; b=7qMtDYzURtCrQN9JWRU7bf5pfv1Rqs7Bhf9scnCsrxOjj8p4biEa2zly7kctAHPcO0ZiAs jLsJ8gZv7nW1PMDA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 71938A3B98; Tue, 20 Jul 2021 15:40:22 +0000 (UTC) Date: Tue, 20 Jul 2021 17:40:22 +0200 Message-ID: From: Takashi Iwai To: Colin King Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] ALSA: opti9xx: fix missing { } around an if block In-Reply-To: <20210720153741.73230-1-colin.king@canonical.com> References: <20210720153741.73230-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Tue, 20 Jul 2021 17:37:41 +0200, Colin King wrote: > > From: Colin Ian King > > Currently the { } braces are missing around an if block causing subsequent > code after the return to become unreachable. Fix this by adding the > missing { }. > > Addresses-Coverity: ("Structurally dead code") > Fixes: 2973ee4a5b54 ("ALSA: opti9xx: Allocate resources with device-managed APIs") > Signed-off-by: Colin Ian King Thanks, applied. Takashi