From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kernel-janitors-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 7BF62C2B9F4
	for <kernel-janitors@archiver.kernel.org>; Tue, 22 Jun 2021 19:33:48 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 4DB4461351
	for <kernel-janitors@archiver.kernel.org>; Tue, 22 Jun 2021 19:33:48 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232415AbhFVTgD (ORCPT
        <rfc822;kernel-janitors@archiver.kernel.org>);
        Tue, 22 Jun 2021 15:36:03 -0400
Received: from smtp-out2.suse.de ([195.135.220.29]:39162 "EHLO
        smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229786AbhFVTgD (ORCPT
        <rfc822;kernel-janitors@vger.kernel.org>);
        Tue, 22 Jun 2021 15:36:03 -0400
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out2.suse.de (Postfix) with ESMTP id 972361FD36;
        Tue, 22 Jun 2021 19:33:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1624390426; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=ZMiJegoSumW3qXEWgZuczWBECh0pakYqt6L4sz12K0o=;
        b=p79kUvf4v44pQ9JLqbQt7cPlI+psr4oDMd0Mevy9MRlsS8JUWimRHzMLNrUPoqxpGtZ0Ay
        qp0lNwiSOWlH9Se2AWfz7XLXWDxlxQRXBbznNKZwZxquIg6XMX2o7bGC0XoaPcjWm5cOrC
        VRYT0fNTKDZNAu1VhKoQ/oXmUnZFQt0=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1624390426;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=ZMiJegoSumW3qXEWgZuczWBECh0pakYqt6L4sz12K0o=;
        b=MPdhP1eYXS13JE4x+JFY51FjAlRbYnXf9iZjEvRNkDkHTAtwFtEOCWDQ91OMy/5OrVBTjy
        TK2Kp1xKTLMqkkDg==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id 72AE1A3B8E;
        Tue, 22 Jun 2021 19:33:46 +0000 (UTC)
Date:   Tue, 22 Jun 2021 21:33:46 +0200
Message-ID: <s5him25pucl.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Jasmin Fazlic <superfassl@gmail.com>,
        Romain Perier <romain.perier@gmail.com>,
        Leon Romanovsky <leon@kernel.org>,
        Huilong Deng <denghuilong@cdjrlc.com>,
        Tong Zhang <ztong0001@gmail.com>,
        Allen Pais <allen.lkml@gmail.com>, alsa-devel@alsa-project.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ALSA: hdsp: fix a test for copy_to_user() failure
In-Reply-To: <YNIzqpVR6L2t/RwJ@mwanda>
References: <YNIzqpVR6L2t/RwJ@mwanda>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <kernel-janitors.vger.kernel.org>
X-Mailing-List: kernel-janitors@vger.kernel.org

On Tue, 22 Jun 2021 21:02:02 +0200,
Dan Carpenter wrote:
> 
> The copy_to_user() function returns the number of bytes remaining to be
> copied.  It doesn't return negatives.
> 
> Fixes: 66c8f75919dd ("ALSA: hdsp: Fix assignment in if condition")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.


Takashi