From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E7408C11 for ; Wed, 22 Mar 2023 15:10:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A608A33C32; Wed, 22 Mar 2023 15:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1679497805; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ua6lboX2Yd4UbZaqn9pHxUmAs2heZnNHKPOytPL/1nY=; b=KeRU2CGU3EONB3JkUnaZSKBXRFd5vDUDjw/WrtI8DYQ0qJp5eE48E7e1RHR/moKnMR1+kN 29/IDxsK+rJ5qYb9Gl9jz/sSvoJdjWYodkguzGT6F9hN8fWjgOOQQtQJsP+0RiR9I9HwY7 Ipa2RsPITqCL5UjFod3djHr+WzYQEj0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1679497805; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ua6lboX2Yd4UbZaqn9pHxUmAs2heZnNHKPOytPL/1nY=; b=gLtA7YJx/ECxx5UYlqnw/UOOooDNsvbdfaTaI04+BTf7Esp7X9r6U0aMYEIIYsiWLIDXah uiX6YmFM+LmNawCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8F8A3138E9; Wed, 22 Mar 2023 15:10:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XHJ7Ik0aG2R2QwAAMHmgww (envelope-from ); Wed, 22 Mar 2023 15:10:05 +0000 Message-ID: <363f4965-87a0-829b-8556-1bc5006e916f@suse.de> Date: Wed, 22 Mar 2023 16:10:05 +0100 Precedence: bulk X-Mailing-List: kernel-tls-handshake@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC PATCH 00/18] nvme: In-kernel TLS support for TCP Content-Language: en-US To: Sagi Grimberg , Christoph Hellwig Cc: Keith Busch , linux-nvme@lists.infradead.org, Chuck Lever , kernel-tls-handshake@lists.linux.dev References: <20230321124325.77385-1-hare@suse.de> <98884644-99f3-7b3c-387a-66fbdd98d4ed@grimberg.me> From: Hannes Reinecke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/22/23 13:53, Sagi Grimberg wrote: > >>>>>> Hi all, >>>>>> >>>>>> finally I've managed to put all things together and enable in-kernel >>>>>> TLS support for NVMe-over-TCP. >>>>> >>>>> Hannes (and Chuck) this is great, I'm very happy to see this! >>>>> >>>>> I'll start a detailed review soon enough. >>>>> >>>>> Thank you for doing this. >>>>> >>>>>> The patchset is based on the TLS upcall mechanism from Chuck Lever >>>>>> (cf '[PATCH v7 0/2] Another crack at a handshake upcall mechanism' >>>>>> posted to the linux netdev list), and requires the 'tlshd' userspace >>>>>> daemon (https://github.com/oracle/ktls-utils) for the actual TLS >>>>>> handshake. >>>>> >>>>> Do you have an actual link to follow for this patch set? >>>> >>>> Sure. >>>> >>>> git.kernel.org:/pub/scm/linux/kernel/git/hare/scsi-devel.git >>>> branch tls-netlink.v7 >>> >>> I meant Chuck's posting on linux-netdev. >> >> To be found here: >> >> > > Nice, it would be great to see code, if you have it, for nvme-cli and/or > nvmetcli as well. PR for libnvme: PR#599 PR for nvme-cli: PR#1868 which is just for updating 'nvme gen-tls-key' to allow the admin to provision 'retained' PSKs in the kernel keyring. For nvmetcli we actually don't need an update; everything works with the existing code :-) Cheers, Hannes