From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE215AFFB for ; Wed, 29 Mar 2023 15:26:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CC35F21A1A; Wed, 29 Mar 2023 15:26:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1680103603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xeSJa3vQAJ+XjA4YbjZhGvIMnv9rsLgj+q8TGfFdRNk=; b=h3sOy7g+ijw6LbMqdM2scfC5IUagJu0Nub91YTic72hWagml+xB0H4XFMeo7BKV/2XlF/1 qmdUKrNF81CpS2KSiXPmPFxxqEGyYxZ39tiYIiaPTDGCk43XVaX6oN3Kl5b8pD8kZ26CVq OUPMtjOyN3UXmebl+hdoAXXObMNXTwo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1680103603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xeSJa3vQAJ+XjA4YbjZhGvIMnv9rsLgj+q8TGfFdRNk=; b=tbCBIGPO020Zrw/Eu/yw9SjgxlRDNFbsCgGcnIjIRTuSBKc48y8SWVhs3CC5qP2FYQmL6S 0ZLg8yKBivMfeUCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5990B139D3; Wed, 29 Mar 2023 15:26:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RJ38ErNYJGRNVgAAMHmgww (envelope-from ); Wed, 29 Mar 2023 15:26:43 +0000 Message-ID: <744cb450-101f-75dc-97e3-0933c26c02cf@suse.de> Date: Wed, 29 Mar 2023 17:26:42 +0200 Precedence: bulk X-Mailing-List: kernel-tls-handshake@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 01/18] nvme-keyring: register '.nvme' keyring and add CONFIG_NVME_TLS Content-Language: en-US To: Sagi Grimberg , Christoph Hellwig Cc: Keith Busch , linux-nvme@lists.infradead.org, Chuck Lever , kernel-tls-handshake@lists.linux.dev References: <20230329135938.46905-1-hare@suse.de> <20230329135938.46905-2-hare@suse.de> <2cfb1620-a09e-87ed-9224-5e94afc0747f@grimberg.me> From: Hannes Reinecke In-Reply-To: <2cfb1620-a09e-87ed-9224-5e94afc0747f@grimberg.me> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/29/23 17:04, Sagi Grimberg wrote: > >> Register a '.nvme' keyring to hold keys for TLS and DH-HMAC-CHAP and >> add a new config option NVME_TLS to enable support for NVMe-TCP/TLS. >> We need a separate keyring for NVMe as the configuration is done >> via individual commands (eg for configfs), and the usual per-session >> or per-process keyrings can't be used. >> >> Signed-off-by: Hannes Reinecke >> --- >>   drivers/nvme/common/Kconfig   |  9 +++++++++ >>   drivers/nvme/common/Makefile  |  1 + >>   drivers/nvme/common/keyring.c | 36 +++++++++++++++++++++++++++++++++++ >>   drivers/nvme/host/core.c      | 19 +++++++++++++++--- >>   include/linux/nvme-keyring.h  | 12 ++++++++++++ >>   5 files changed, 74 insertions(+), 3 deletions(-) >>   create mode 100644 drivers/nvme/common/keyring.c >>   create mode 100644 include/linux/nvme-keyring.h >> >> diff --git a/drivers/nvme/common/Kconfig b/drivers/nvme/common/Kconfig >> index 4514f44362dd..b6fff16da1fb 100644 >> --- a/drivers/nvme/common/Kconfig >> +++ b/drivers/nvme/common/Kconfig >> @@ -2,3 +2,12 @@ >>   config NVME_COMMON >>          tristate >> + >> +config NVME_TLS > > Better to call it NVME_TCP_TLS... although not a biggie, should be > well understood this is tcp > Sure. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman