From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1665B5683 for ; Mon, 3 Apr 2023 14:13:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 427F81FFC3; Mon, 3 Apr 2023 14:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1680531226; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xLPI3C1EeVbUw6oXyOWF//ALGry4R5vG6k4f/LjCiFc=; b=LRopvu8GTBXFVssmbjg2y5PEM5jWraoKsllhavFa0LMNIgXJeSLxl3mTeV7XgNwA9Rfutw OggV5CqPq+IO4AX3DUVHC46wxob2kTNPX+/YyP5trKlkn8flLTOYd5Prv1JFUhYN48tukx 0TpRKBveerajAdW3zNN3YMH9JAtQd7M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1680531226; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xLPI3C1EeVbUw6oXyOWF//ALGry4R5vG6k4f/LjCiFc=; b=Dwh+MknTyz0phYk3dPXP3vheJOXAynlK4/7xKj+zrElq/phL+1dtvZnEDDBiVYZoceBUDB ZO9pW3CV/5iTPsCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 211E113416; Mon, 3 Apr 2023 14:13:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iafoBhrfKmS5DwAAMHmgww (envelope-from ); Mon, 03 Apr 2023 14:13:46 +0000 Message-ID: Date: Mon, 3 Apr 2023 16:13:45 +0200 Precedence: bulk X-Mailing-List: kernel-tls-handshake@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 18/18] nvmet-tcp: add configfs attribute 'param_keyring' Content-Language: en-US To: Sagi Grimberg , Christoph Hellwig Cc: Keith Busch , linux-nvme@lists.infradead.org, Chuck Lever , kernel-tls-handshake@lists.linux.dev References: <20230329135938.46905-1-hare@suse.de> <20230329135938.46905-19-hare@suse.de> <60ff89b4-5d63-a6db-18b1-e0f28055c5d9@grimberg.me> From: Hannes Reinecke In-Reply-To: <60ff89b4-5d63-a6db-18b1-e0f28055c5d9@grimberg.me> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/3/23 15:03, Sagi Grimberg wrote: > >> Add a configfs attribute to list and change the default keyring. > > is the keyring an attribute of a port? or a subsystem? Why the choice > of making it per port? > As per discussion at fmds each port might want to use different credentials. We can move it to subsystems if we decide we don't want to support that use-case. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions Germany GmbH, Frankenstr. 146, 90461 Nürnberg Managing Directors: I. Totev, A. Myers, A. McDonald, M. B. Moerman (HRB 36809, AG Nürnberg)