From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: David Hildenbrand <david@redhat.com>,
Muhammad Usama Anjum <usama.anjum@collabora.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
kernel@collabora.com, kernelci@groups.io,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH V3] selftests: vm: Add test for Soft-Dirty PTE bit
Date: Thu, 03 Mar 2022 13:39:20 -0500 [thread overview]
Message-ID: <87o82mkhif.fsf@collabora.com> (raw)
In-Reply-To: <6133317f-4da0-3aae-f352-b75f0f94dbd4@linuxfoundation.org> (Shuah Khan's message of "Thu, 3 Mar 2022 11:19:35 -0700")
Shuah Khan <skhan@linuxfoundation.org> writes:
> On 2/28/22 2:37 AM, David Hildenbrand wrote:
>> On 24.02.22 22:23, Muhammad Usama Anjum wrote:
>>> This introduces three tests:
>>> 1) Sanity check soft dirty basic semantics: allocate area, clean, dirty,
>>> check if the SD bit flipped.
>>> 2) Check VMA reuse: validate the VM_SOFTDIRTY usage
>>> 3) Check soft-dirty on huge pages
>>>
>>> This was motivated by Will Deacon's fix commit 912efa17e512 ("mm: proc:
>>> Invalidate TLB after clearing soft-dirty page state"). I was tracking the
>>> same issue that he fixed, and this test would have caught it.
>>>
>> A note that madv_populate.c already contains some SOFTDIRTY tests
>> regarding MADV_POPULATE. Eventually we want to factor out
>> softdirty/pagemap handling+checks for easier reuse.
>>
>
> Is this patch unnecessary then?
It is not unnecessary since the madv test doesn't cover the bug tested
here, afaik. But, as mentioned when I originally submitted this patch,
it should be merged into selftests/vm/madv_populate.c or, at least,
reuse that existing infrastructure.
https://lore.kernel.org/lkml/87lf553z5g.fsf@collabora.com/
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2022-03-03 18:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 21:23 [PATCH V3] selftests: vm: Add test for Soft-Dirty PTE bit Usama
2022-02-26 0:35 ` Shuah Khan
2022-02-28 6:55 ` Usama
2022-03-03 18:18 ` Shuah Khan
2022-02-28 9:37 ` David Hildenbrand
2022-03-03 18:19 ` Shuah Khan
2022-03-03 18:39 ` Gabriel Krisman Bertazi [this message]
2022-03-03 21:46 ` Shuah Khan
2022-03-04 16:14 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o82mkhif.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=kernel@collabora.com \
--cc=kernelci@groups.io \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=usama.anjum@collabora.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).