Kernel Newbies archive on lore.kernel.org
 help / color / Atom feed
From: "Alexander Ivanov" <amivanov@fastmail.com>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
	"Jean Delvare" <jdelvare@suse.de>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Bjørn Mork" <bjorn@mork.no>,
	kernelnewbies@kernelnewbies.org
Subject: Re: GPIO Driver for Skylake-Y PCH
Date: Sat, 15 Jun 2019 12:38:34 -0700
Message-ID: <06e1f687-b16c-4137-b9ff-14dfc681cca3@www.fastmail.com> (raw)
In-Reply-To: <15515.1560627024@turing-police>

[-- Attachment #1.1: Type: text/plain, Size: 2387 bytes --]



On Sat, 15 Jun 2019 12:31 -07:00, Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
> On Fri, 14 Jun 2019 15:40:59 -0700, "Alexander Ivanov" said:
> 
> (Adding likely knowledgeable people to the recipients)
> 
> Jean, Andy, Linus: The situation thus far: Alexander has a system with this GPIO on it:
> 
> > lspci -vvvnns 1f.1
> > 00:1f.1 Memory controller [0580]: Intel Corporation Device [8086:9d20] (rev 21)
> > Subsystem: Gigabyte Technology Co., Ltd Device [1458:1000]
> > Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
> > Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> > Latency: 0
> > Region 0: Memory at 7d000000 (64-bit, non-prefetchable) [size=16M]
> 
> The obvious first thing to try was:
> 
> diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
> index 1d99293096f2..19884b5b2a74 100644
> --- a/drivers/gpio/gpio-pch.c
> +++ b/drivers/gpio/gpio-pch.c
> @@ -439,6 +439,7 @@ static SIMPLE_DEV_PM_OPS(pch_gpio_pm_ops, pch_gpio_suspend, pch_gpio_resume);
> 
> static const struct pci_device_id pch_gpio_pcidev_id[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x9d20) },
> { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) },
> { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8043) },
> { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8803) },
> 
> and that died thusly when attempted to load:
> 
> [ 105.965846] pci 0000:00:1f.1: [8086:9d20] type 00 class 0x058000
> [ 105.965928] pci 0000:00:1f.1: reg 0x10: [mem 0xfd000000-0xfdffffff 64bit]
> [ 105.967084] pci 0000:00:1f.1: BAR 0: assigned [mem 0x7d000000-0x7dffffff 64bit]
> [ 105.978037] pch_gpio 0000:00:1f.1: pch_gpio_probe : pci_iomap FAILED
> [ 105.978194] pch_gpio 0000:00:1f.1: pch_gpio_probe Failed returns -12
> [ 105.978317] pch_gpio: probe of 0000:00:1f.1 failed with error -12
> 
> So obviously an older kernel. Not sure what release Alexander is on, but
> a 'git log' against this week's linux-next tree didn't show anything that was
> an obvious fix for a similar problem.

This is fedora 25 running 4.8.6 kernel.


> 
> Any ideas?
> 
> 
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
> 

[-- Attachment #1.2: Type: text/html, Size: 3365 bytes --]

<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div><br></div><div>On Sat, 15 Jun 2019 12:31 -07:00, Valdis Klētnieks &lt;valdis.kletnieks@vt.edu&gt; wrote:<br></div><blockquote type="cite" id="qt"><div>On Fri, 14 Jun 2019 15:40:59 -0700, "Alexander Ivanov" said:<br></div><div><br></div><div>(Adding likely knowledgeable&nbsp; people to the recipients)<br></div><div><br></div><div>Jean,&nbsp; Andy, Linus: The situation thus far:&nbsp; Alexander has a system with this GPIO on it:<br></div><div><br></div><div>&gt; lspci -vvvnns 1f.1<br></div><div>&gt; 00:1f.1 Memory controller [0580]: Intel Corporation Device [8086:9d20] (rev 21)<br></div><div>&gt;&nbsp; Subsystem: Gigabyte Technology Co., Ltd Device [1458:1000]<br></div><div>&gt;&nbsp; Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-<br></div><div>&gt;&nbsp; Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast &gt;TAbort- &lt;TAbort- &lt;MAbort- &gt;SERR- &lt;PERR- INTx-<br></div><div>&gt;&nbsp; Latency: 0<br></div><div>&gt;&nbsp; Region 0: Memory at 7d000000 (64-bit, non-prefetchable) [size=16M]<br></div><div><br></div><div>The obvious first thing to try was:<br></div><div><br></div><div>diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c<br></div><div>index 1d99293096f2..19884b5b2a74 100644<br></div><div>--- a/drivers/gpio/gpio-pch.c<br></div><div>+++ b/drivers/gpio/gpio-pch.c<br></div><div>@@ -439,6 +439,7 @@ static SIMPLE_DEV_PM_OPS(pch_gpio_pm_ops, pch_gpio_suspend, pch_gpio_resume);<br></div><div><br></div><div>static const struct pci_device_id pch_gpio_pcidev_id[] = {<br></div><div>{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) },<br></div><div>+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x9d20) },<br></div><div>{ PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) },<br></div><div>{ PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8043) },<br></div><div>{ PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8803) },<br></div><div><br></div><div>and that died thusly when attempted to load:<br></div><div><br></div><div>[ 105.965846] pci 0000:00:1f.1: [8086:9d20] type 00 class 0x058000<br></div><div>[ 105.965928] pci 0000:00:1f.1: reg 0x10: [mem 0xfd000000-0xfdffffff 64bit]<br></div><div>[ 105.967084] pci 0000:00:1f.1: BAR 0: assigned [mem 0x7d000000-0x7dffffff 64bit]<br></div><div>[ 105.978037] pch_gpio 0000:00:1f.1: pch_gpio_probe : pci_iomap FAILED<br></div><div>[ 105.978194] pch_gpio 0000:00:1f.1: pch_gpio_probe Failed returns -12<br></div><div>[ 105.978317] pch_gpio: probe of 0000:00:1f.1 failed with error -12<br></div><div><br></div><div>So obviously an older kernel.&nbsp; Not sure what release Alexander is on, but<br></div><div>a 'git log' against this week's linux-next tree didn't show anything that was<br></div><div>an obvious fix for a similar problem.<br></div></blockquote><div><br></div><div>This is fedora 25 running 4.8.6 kernel.<br></div><div><br></div><div><br></div><blockquote type="cite" id="qt"><div><br></div><div>Any ideas?<br></div><div><br></div><div><br></div><div>_______________________________________________<br></div><div>Kernelnewbies mailing list<br></div><div>Kernelnewbies@kernelnewbies.org<br></div><div>https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies<br></div><div><br></div></blockquote><div><br></div></body></html>

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

  reply index

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 17:58 Alexander Ivanov
2019-06-14 18:46 ` Valdis Klētnieks
2019-06-14 19:01   ` Alexander Ivanov
2019-06-14 19:09     ` Valdis Klētnieks
2019-06-14 20:25       ` Alexander Ivanov
2019-06-14 22:40         ` Alexander Ivanov
2019-06-15  8:53           ` Bjørn Mork
2019-06-15 19:30           ` Valdis Klētnieks
2019-06-15 19:38             ` Alexander Ivanov [this message]
2019-06-15 19:56               ` Greg KH
2019-06-16  1:50               ` Valdis Klētnieks
2019-06-16  2:45                 ` Alexander Ivanov
2019-06-16  8:54                   ` Bjørn Mork
2019-06-17  8:06             ` Andy Shevchenko
2019-06-18  0:00               ` Alexander Ivanov
2019-06-18  8:40                 ` Andy Shevchenko
2019-06-18 14:48                   ` Valdis Klētnieks
2019-06-18 15:57                     ` Andy Shevchenko
2019-06-18 16:17                       ` Alexander Ivanov
2019-06-20 21:02                   ` Alexander Ivanov
2019-06-21 10:12                     ` Andy Shevchenko
2019-06-21 17:39                       ` Alexander Ivanov
2019-06-24 18:39                         ` Alexander Ivanov
2019-06-25 11:08                           ` Andy Shevchenko
2019-06-25 14:10                             ` Linus Walleij
2019-07-10 16:04                               ` Andy Shevchenko
2019-06-14 19:12   ` Bjørn Mork

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06e1f687-b16c-4137-b9ff-14dfc681cca3@www.fastmail.com \
    --to=amivanov@fastmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bjorn@mork.no \
    --cc=jdelvare@suse.de \
    --cc=kernelnewbies@kernelnewbies.org \
    --cc=linus.walleij@linaro.org \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Kernel Newbies archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kernelnewbies/0 kernelnewbies/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kernelnewbies kernelnewbies/ https://lore.kernel.org/kernelnewbies \
		kernelnewbies@kernelnewbies.org kernelnewbies@archiver.kernel.org
	public-inbox-index kernelnewbies


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernelnewbies.kernelnewbies


AGPL code for this site: git clone https://public-inbox.org/ public-inbox