From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A77E2C31E50 for ; Sat, 15 Jun 2019 19:39:27 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C2ED2184D for ; Sat, 15 Jun 2019 19:39:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=fastmail.com header.i=@fastmail.com header.b="olun6H5n"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="MFNtuapy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C2ED2184D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=fastmail.com Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.92) (envelope-from ) id 1hcEWC-0002Yc-IO; Sat, 15 Jun 2019 15:39:16 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by shelob.surriel.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hcEWA-0002YW-9r for kernelnewbies@kernelnewbies.org; Sat, 15 Jun 2019 15:39:14 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 097E53DB; Sat, 15 Jun 2019 15:39:11 -0400 (EDT) Received: from imap4 ([10.202.2.54]) by compute3.internal (MEProxy); Sat, 15 Jun 2019 15:39:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=PQxfgsh2WAU++mTF3iCdIxegUG8qxc5 or11QsNY0KEs=; b=olun6H5nNvOBfTOMW3BmRf1+MSSTm6Mu2nXdwFhP/nX2u9l kELtZzh5c9UQJqbMwKJ4N4J3xcugk0QbfnXd9XoSLIqZjko5xN0DYHGaJpHIKhFD +udHPWb8wofFOzFyX17+gRnYixHliXCAf6ZoVV6emg0WRBfZI7X8+T4MCfDmQCdL IGGuQwuTK2XzgwWTCj0Z6q2eaBx7X3e6ov/34ME0ynlBZWN5ppklHaWUXCkuhiNM cYRjdSjdc5fqaOrPqckeZNKbs8EMCou5r56o6QA5ChRSy9srGq1Kxpnmx/O+sxqc 5XFgUjkjT/1rw1uBRQyQnL760BvRT/o1gvozhkg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=PQxfgs h2WAU++mTF3iCdIxegUG8qxc5or11QsNY0KEs=; b=MFNtuapyL/PujYkpQyqi6G XraIiIdvSw6icLbiAzTYZlJvjcefqvtoO7X5wn0eJYVCjNtLU9Td/uJMJ8vNggnY TAGcpUgIVicQhecerzntrg2pRFgbPEbn/Fh4L6HugliprbjBiC7wDAR9QDCoRm4L nZnbYOsPPuR8QWvB0Umhheo1//XC5Nf3YlxCWSU2nSEW71VH3KcTj6SC7IEGqR2+ BV0YyuFiwSc193XxMmZb7hGkT+UlSMVFJPJC8aEAFGkfZoXcBIWKeWMgQbuCV0Nz cXEdFDxDkQaUaM/hE81csrvUTJU5PiW+deQz7UgtnBFonCVlO7PeVGb1cwJmnbgQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudeifedgudegvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsegrtderreerreejnecuhfhrohhmpedftehl vgigrghnuggvrhcukfhvrghnohhvfdcuoegrmhhivhgrnhhovhesfhgrshhtmhgrihhlrd gtohhmqeenucffohhmrghinhepkhgvrhhnvghlnhgvfigsihgvshdrohhrghenucfrrghr rghmpehmrghilhhfrhhomheprghmihhvrghnohhvsehfrghsthhmrghilhdrtghomhenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 807BC3C00A0; Sat, 15 Jun 2019 15:39:10 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.6-663-gf46ad30-fmstable-20190607v1 Mime-Version: 1.0 Message-Id: <06e1f687-b16c-4137-b9ff-14dfc681cca3@www.fastmail.com> In-Reply-To: <15515.1560627024@turing-police> References: <23630.1560537979@turing-police> <59c1b6d6-0545-4249-90cb-d1152b6ea728@www.fastmail.com> <25501.1560539366@turing-police> <15515.1560627024@turing-police> Date: Sat, 15 Jun 2019 12:38:34 -0700 From: "Alexander Ivanov" To: =?UTF-8?Q?Valdis_Kl=C4=93tnieks?= , "Jean Delvare" Subject: Re: GPIO Driver for Skylake-Y PCH Cc: Linus Walleij , Andy Shevchenko , =?UTF-8?Q?Bj=C3=B8rn_Mork?= , kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0663162133826559335==" Errors-To: kernelnewbies-bounces@kernelnewbies.org --===============0663162133826559335== Content-Type: multipart/alternative; boundary=d1cd5e64bb964ddebd48efe59ff304a2 --d1cd5e64bb964ddebd48efe59ff304a2 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, 15 Jun 2019 12:31 -07:00, Valdis Kl=C4=93tnieks wrote: > On Fri, 14 Jun 2019 15:40:59 -0700, "Alexander Ivanov" said: >=20 > (Adding likely knowledgeable people to the recipients) >=20 > Jean, Andy, Linus: The situation thus far: Alexander has a system with= this GPIO on it: >=20 > > lspci -vvvnns 1f.1 > > 00:1f.1 Memory controller [0580]: Intel Corporation Device [8086:9d2= 0] (rev 21) > > Subsystem: Gigabyte Technology Co., Ltd Device [1458:1000] > > Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- = Stepping- SERR- FastB2B- DisINTx- > > Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=3Dfast >TAbort- SERR- > Latency: 0 > > Region 0: Memory at 7d000000 (64-bit, non-prefetchable) [size=3D16M]= >=20 > The obvious first thing to try was: >=20 > diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c > index 1d99293096f2..19884b5b2a74 100644 > --- a/drivers/gpio/gpio-pch.c > +++ b/drivers/gpio/gpio-pch.c > @@ -439,6 +439,7 @@ static SIMPLE_DEV_PM_OPS(pch_gpio_pm_ops, pch_gpio= _suspend, pch_gpio_resume); >=20 > static const struct pci_device_id pch_gpio_pcidev_id[] =3D { > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) }, > + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x9d20) }, > { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) }, > { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8043) }, > { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8803) }, >=20 > and that died thusly when attempted to load: >=20 > [ 105.965846] pci 0000:00:1f.1: [8086:9d20] type 00 class 0x058000 > [ 105.965928] pci 0000:00:1f.1: reg 0x10: [mem 0xfd000000-0xfdffffff 6= 4bit] > [ 105.967084] pci 0000:00:1f.1: BAR 0: assigned [mem 0x7d000000-0x7dff= ffff 64bit] > [ 105.978037] pch_gpio 0000:00:1f.1: pch_gpio_probe : pci_iomap FAILED= > [ 105.978194] pch_gpio 0000:00:1f.1: pch_gpio_probe Failed returns -12= > [ 105.978317] pch_gpio: probe of 0000:00:1f.1 failed with error -12 >=20 > So obviously an older kernel. Not sure what release Alexander is on, b= ut > a 'git log' against this week's linux-next tree didn't show anything t= hat was > an obvious fix for a similar problem. This is fedora 25 running 4.8.6 kernel. >=20 > Any ideas? >=20 >=20 > _______________________________________________ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >=20 --d1cd5e64bb964ddebd48efe59ff304a2 Content-Type: text/html;charset=utf-8 Content-Transfer-Encoding: quoted-printable

=
On Sat, 15 Jun 2019 12:31 -07:00, Valdis Kl=C4=93tnieks &= lt;valdis.kletnieks@vt.edu> wrote:
On Fri, 14 Jun 2019 15:40:59 -0700, "Alexander Ivanov" s= aid:

(Adding likely knowledgeable  peo= ple to the recipients)

Jean,  Andy, Li= nus: The situation thus far:  Alexander has a system with this GPIO= on it:

> lspci -vvvnns 1f.1
> 00:1f.1 Memory controller [0580]: Intel Corporation Device [8086= :9d20] (rev 21)
>  Subsystem: Gigabyte Technology = Co., Ltd Device [1458:1000]
>  Control: I/O- Mem+ = BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B= - DisINTx-
>  Status: Cap- 66MHz- UDF- FastB2B- Pa= rErr- DEVSEL=3Dfast >TAbort- <TAbort- <MAbort- >SERR- <PE= RR- INTx-
>  Latency: 0
>  R= egion 0: Memory at 7d000000 (64-bit, non-prefetchable) [size=3D16M]
<= /div>

The obvious first thing to try was:

diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gp= io-pch.c
index 1d99293096f2..19884b5b2a74 100644
=
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio= -pch.c
@@ -439,6 +439,7 @@ static SIMPLE_DEV_PM_OPS(pch_gp= io_pm_ops, pch_gpio_suspend, pch_gpio_resume);

<= div>static const struct pci_device_id pch_gpio_pcidev_id[] =3D {
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) },
+ { PC= I_DEVICE(PCI_VENDOR_ID_INTEL, 0x9d20) },
{ PCI_DEVICE(PCI_= VENDOR_ID_ROHM, 0x8014) },
{ PCI_DEVICE(PCI_VENDOR_ID_ROHM= , 0x8043) },
{ PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8803) },

and that died thusly when attempted to load:=

[ 105.965846] pci 0000:00:1f.1: [8086:9d20= ] type 00 class 0x058000
[ 105.965928] pci 0000:00:1f.1: r= eg 0x10: [mem 0xfd000000-0xfdffffff 64bit]
[ 105.967084] p= ci 0000:00:1f.1: BAR 0: assigned [mem 0x7d000000-0x7dffffff 64bit]
[ 105.978037] pch_gpio 0000:00:1f.1: pch_gpio_probe : pci_iomap= FAILED
[ 105.978194] pch_gpio 0000:00:1f.1: pch_gpio_prob= e Failed returns -12
[ 105.978317] pch_gpio: probe of 0000= :00:1f.1 failed with error -12

So obviously= an older kernel.  Not sure what release Alexander is on, but
a 'git log' against this week's linux-next tree didn't show any= thing that was
an obvious fix for a similar problem.

This is fedora 25 running 4.8.6 ker= nel.



Any ideas?


=
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.or= g
https://lists.kernelnewbies.org/mailman/listinfo/kerneln= ewbies


--d1cd5e64bb964ddebd48efe59ff304a2-- --===============0663162133826559335== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies --===============0663162133826559335==--