From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D4F8C31E50 for ; Sat, 15 Jun 2019 19:30:58 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03C5B2184B for ; Sat, 15 Jun 2019 19:30:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03C5B2184B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vt.edu Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.92) (envelope-from ) id 1hcENp-0002JU-NV; Sat, 15 Jun 2019 15:30:37 -0400 Received: from omr2.cc.ipv6.vt.edu ([2607:b400:92:8400:0:33:fb76:806e] helo=omr2.cc.vt.edu) by shelob.surriel.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hcENn-0002JO-7o for kernelnewbies@kernelnewbies.org; Sat, 15 Jun 2019 15:30:35 -0400 Received: from mr5.cc.vt.edu (junk.cc.ipv6.vt.edu [IPv6:2607:b400:92:9:0:9d:8fcb:4116]) by omr2.cc.vt.edu (8.14.4/8.14.4) with ESMTP id x5FJUXK4026791 for ; Sat, 15 Jun 2019 15:30:33 -0400 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mr5.cc.vt.edu (8.14.7/8.14.7) with ESMTP id x5FJURDH012069 for ; Sat, 15 Jun 2019 15:30:32 -0400 Received: by mail-qk1-f199.google.com with SMTP id j128so5256647qkd.23 for ; Sat, 15 Jun 2019 12:30:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:content-transfer-encoding:date:message-id; bh=OAn9dlVU1Yce8y1chAyVGuVUxrVRjtlkgTbPiBjlFew=; b=nvuar+KwHqRYZ3oXYCkhRS18giYpDiFbiIvihpw8KEuMyYc7hcCsspG9FZt06XHBiY i+QXkZa3TtKfdNg+pCjVdx97WbBVv/Of58mr1G/yrWbbwyMPVEpdjahAL8Uy/JVCc5xi +VVGLujec0mG3A++lMvbxWJrvhAR7vCxTBzvv4WFEuyqxu8ErEagwhIwOEFJ0/uJTJye bV3C6f2t22ZfPexHMqGT1YPFdmrTog7ZmJGS29qGoHZbbEhCHU3rWwjQHn6jGrdc19Cp t36eruSeytN0XfzW0wz/z6mIr1Znw5YRLZMYhNAgigcRommfKM4ielsJ9KnwQ/yhrIR/ 7spw== X-Gm-Message-State: APjAAAU9D+0pdnbwHTw+XHkUcwN7HLi+bdXEqMMon6yhd9c2SGQ2UFt8 AYEpMGCqWSHkt/W6k+rp7KHkQt3hr4Zwa5eU9TmYoKAnjTw7aoxESMniG4KWY4t8H3tWVZ0Sief IKR1x92ith3OVdUKHXNZ4G0wGVwSW3F0Zr/QLmzI= X-Received: by 2002:ac8:1e15:: with SMTP id n21mr60214019qtl.20.1560627027782; Sat, 15 Jun 2019 12:30:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqxUBhUJXvwDpRgNeuxYdE8goz3sNzifrIn+goWw8cLyRbR2wHRaWnkFpDdmpLxGne9qV5eHEA== X-Received: by 2002:ac8:1e15:: with SMTP id n21mr60214004qtl.20.1560627027501; Sat, 15 Jun 2019 12:30:27 -0700 (PDT) Received: from turing-police ([2601:5c0:c001:4341::359]) by smtp.gmail.com with UTF8SMTPSA id t8sm4946230qtc.80.2019.06.15.12.30.25 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 15 Jun 2019 12:30:25 -0700 (PDT) From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: "Alexander Ivanov" , Jean Delvare Subject: Re: GPIO Driver for Skylake-Y PCH In-Reply-To: References: <23630.1560537979@turing-police> <59c1b6d6-0545-4249-90cb-d1152b6ea728@www.fastmail.com> <25501.1560539366@turing-police> Mime-Version: 1.0 Date: Sat, 15 Jun 2019 15:30:24 -0400 Message-ID: <15515.1560627024@turing-police> Cc: Linus Walleij , Andy Shevchenko , Bjørn Mork , kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8101428194837405887==" Errors-To: kernelnewbies-bounces@kernelnewbies.org --===============8101428194837405887== Content-Type: multipart/signed; boundary="==_Exmh_1560627024_1697P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit --==_Exmh_1560627024_1697P Content-Type: text/plain; charset=us-ascii On Fri, 14 Jun 2019 15:40:59 -0700, "Alexander Ivanov" said: (Adding likely knowledgeable people to the recipients) Jean, Andy, Linus: The situation thus far: Alexander has a system with this GPIO on it: > lspci -vvvnns 1f.1 > 00:1f.1 Memory controller [0580]: Intel Corporation Device [8086:9d20] (rev 21) > Subsystem: Gigabyte Technology Co., Ltd Device [1458:1000] > Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- > Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- Latency: 0 > Region 0: Memory at 7d000000 (64-bit, non-prefetchable) [size=16M] The obvious first thing to try was: diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c index 1d99293096f2..19884b5b2a74 100644 --- a/drivers/gpio/gpio-pch.c +++ b/drivers/gpio/gpio-pch.c @@ -439,6 +439,7 @@ static SIMPLE_DEV_PM_OPS(pch_gpio_pm_ops, pch_gpio_suspend, pch_gpio_resume); static const struct pci_device_id pch_gpio_pcidev_id[] = { { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) }, + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x9d20) }, { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) }, { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8043) }, { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8803) }, and that died thusly when attempted to load: [ 105.965846] pci 0000:00:1f.1: [8086:9d20] type 00 class 0x058000 [ 105.965928] pci 0000:00:1f.1: reg 0x10: [mem 0xfd000000-0xfdffffff 64bit] [ 105.967084] pci 0000:00:1f.1: BAR 0: assigned [mem 0x7d000000-0x7dffffff 64bit] [ 105.978037] pch_gpio 0000:00:1f.1: pch_gpio_probe : pci_iomap FAILED [ 105.978194] pch_gpio 0000:00:1f.1: pch_gpio_probe Failed returns -12 [ 105.978317] pch_gpio: probe of 0000:00:1f.1 failed with error -12 So obviously an older kernel. Not sure what release Alexander is on, but a 'git log' against this week's linux-next tree didn't show anything that was an obvious fix for a similar problem. Any ideas? --==_Exmh_1560627024_1697P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Comment: Exmh version 2.9.0 11/07/2018 iQIVAwUBXQVHTwdmEQWDXROgAQIkSA//dWADHzNFh2YYxpZ2Bfl3nPNaKY3j190k ezgdCwnhbh7dSzLCJ20itswedUaOuDgZGF4zgo8Vjy4XbIRPeqm7IfbnxE/H1j/K x5h4Jg0wH3xGP8h7oVO0c3PhQHsru5yBvzb2s7uxMLO05t6NjVX2nDqCmTTd5m+s 67Ev9NGQ8jLDt0YkQFFJSMg6SP7j/bfwybkuYflDN9vh8kKzwmAaONsBje54tP6E nNC9/65oQEAt9m2CgrsKHF39BadHoNrMciRHgMfQZvIaX73KGtDVbF1vjFG9EbkU 2EZqR7aFh1mYPKYfnqjgfBMsQKMK9PZudAHwWY33r/ZORgaCyHjDldRn+rcTizBM wnQA1ISsdmgRBZyFxZZOfoZJOAI/9IHJfLFXgU9uA2eAiay1ymsY5xBtoTam7dGV I8eM7nUGFes6W6kWIIpzVum/wfTLa2wtuhQat6wXeSZl+++F3FK7fGklLJJOAFPg HgXJP3H0Ri03ILcVQ8KfM5EY89xnbd56e5NU9ci5KEJaokcjujjc4BqJze/m3Vtb xYYCagH6C03BpRafMcsXB8dIeuKJYV0y2s0xKXoS80Ub0uvXcmRva4vXYD6siTPL JL7bHEkBIMhC3fFX73jAtoN1ujRvUhQCgkxSRZJrzPx7P7TMl6kItbzNOPcNGZsv 9dbcBMn7GbQ= =Wm9/ -----END PGP SIGNATURE----- --==_Exmh_1560627024_1697P-- --===============8101428194837405887== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies --===============8101428194837405887==--