Kernel Newbies archive on lore.kernel.org
 help / color / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: Pintu Agarwal <pintu.ping@gmail.com>,
	open list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	 Kernelnewbies <kernelnewbies@kernelnewbies.org>,
	linux-pm@vger.kernel.org
Subject: Re: [IMX] [DRM]: suspend/resume support
Date: Tue, 18 Jun 2019 09:01:41 +0200
Message-ID: <1560841301.21660.9.camel@suse.com> (raw)
In-Reply-To: <CAOuPNLiBA9VjEoG_D2y2O5mKiqsDNW1VZXOk1eWXpGY+h86acg@mail.gmail.com>

Am Montag, den 17.06.2019, 19:19 +0530 schrieb Pintu Agarwal:

> Currently, I am trying to understand what needs to be taken care
> during suspend/resume.

You need to take care of

* wakeup sources
* not requiring services of devices higher up in the tree.

> With some reference, I figured out that hdmi power off/on needs to be
> done during suspend/resume.

That would make sense.

First of all you need to understand that the generic model is, well,
generic. Now this may look like a tautology, so let me explain.
A generic model cannot tell you how to save power on a specific
hardware. It exists to model dependencies among subsystems and
to help you.

The suspend() call is a notification which tells you that the rest
of the system will not require your services until resume() is
called().
That means that after resume() your driver must be functional again.

And it means that between suspend() and resume() you cannot touch
your device because what is above you in the tree need not be
functional.

> But after resume, system is hanging.
> It seems like vblank events are not getting triggered after the resume.
> May be irq remains disabled after resume, I need to figure out some
> way to enable the all the irqs again.

In your case it looks like parts of dw_hdmi_imx_bind() need to be
redone in resume().

	HTH
		Oliver


_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

  reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 13:49 Pintu Agarwal
2019-06-18  7:01 ` Oliver Neukum [this message]
2019-06-18 14:02 ` Fabio Estevam
2019-06-18 14:45   ` Pintu Agarwal
2019-06-18 15:09     ` Fabio Estevam
2019-06-19 13:33       ` Pintu Agarwal
2019-06-19 13:44         ` Fabio Estevam
2019-06-19 15:04           ` Pintu Agarwal
2019-06-19 15:11             ` Fabio Estevam
2019-06-19 15:29               ` Pintu Agarwal
2019-06-21 15:12                 ` Pintu Agarwal
2019-06-21 15:40                   ` Fabio Estevam
2019-06-22  8:13                     ` Pintu Agarwal
2019-07-01 14:25                       ` Pintu Agarwal
2019-07-11 15:29                         ` [IMX] [DRM]: help in analyzing clock_summary rate difference Pintu Agarwal
2019-06-19 15:04         ` [IMX] [DRM]: suspend/resume support Greg KH
2019-06-19 15:17           ` Pintu Agarwal
2019-06-19 16:26             ` Valdis Klētnieks
2019-06-21 15:04               ` Pintu Agarwal

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1560841301.21660.9.camel@suse.com \
    --to=oneukum@suse.com \
    --cc=kernelnewbies@kernelnewbies.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pintu.ping@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Kernel Newbies archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kernelnewbies/0 kernelnewbies/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kernelnewbies kernelnewbies/ https://lore.kernel.org/kernelnewbies \
		kernelnewbies@kernelnewbies.org kernelnewbies@archiver.kernel.org
	public-inbox-index kernelnewbies


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernelnewbies.kernelnewbies


AGPL code for this site: git clone https://public-inbox.org/ public-inbox