From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: jim.cromie@gmail.com
Cc: kernelnewbies <kernelnewbies@kernelnewbies.org>
Subject: Re: '-D' 'KBUILD_MODSYM=main - like KBUILD_MODNAME, without the quotes ?
Date: Thu, 28 Jan 2021 18:57:04 -0500 [thread overview]
Message-ID: <169957.1611878224@turing-police> (raw)
In-Reply-To: <CAJfuBxwYZ_MwQZAn3OTBO=591uba9xCzXW7mERT3hTfxqt8s6w@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 686 bytes --]
On Thu, 28 Jan 2021 12:11:54 -0700, jim.cromie@gmail.com said:
> In my hacking, Im finding this useful.
> it adds a version of KBUILD_MODNAME without the quotes
OK, I'll bite. When and how is this useful?
> KBUILD_MODNAME has the quotes for a reason;
Hint: do a "git grep KBUILD_MODNAME", look at how it's used, and
think about how invasive a patch to change it would be...
(And pay heed to the comment in arch/sparc/include/asm/vio.h -
it means that there's second-order effects to deal with as well...)
> Afterall, __stringify() could add the quotes for cases where it was needed.Afterall, __stringify() could add the quotes for cases where it was needed.
How would it know?
[-- Attachment #1.2: Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2021-01-28 23:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 19:11 '-D' 'KBUILD_MODSYM=main - like KBUILD_MODNAME, without the quotes ? jim.cromie
2021-01-28 23:57 ` Valdis Klētnieks [this message]
2021-01-29 0:16 ` jim.cromie
2021-01-29 2:04 ` Valdis Klētnieks
2021-01-29 8:32 ` jim.cromie
2021-01-29 9:07 ` jim.cromie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169957.1611878224@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=jim.cromie@gmail.com \
--cc=kernelnewbies@kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).