kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: valdis.kletnieks@vt.edu
To: arshad hussain <arshad.super@gmail.com>
Cc: linux-erofs@lists.ozlabs.org, Gao Xiang <hsiangkao@aol.com>,
	miaoxie@huawei.com, Gao Xiang <hsiangkao@gmx.com>,
	kernelnewbies <kernelnewbies@kernelnewbies.org>
Subject: Re: [PATCH 1/1] staging: erofs: Add function comment for erofs/super.c
Date: Tue, 12 Mar 2019 14:40:36 -0400	[thread overview]
Message-ID: <17926.1552416036@turing-police> (raw)
In-Reply-To: <CAKsu7qwsSeN3XT=f-cz6wOMdwAHHhDJpWnNk_2epHu5J+F0+VA@mail.gmail.com>

On Tue, 12 Mar 2019 23:33:47 +0530, arshad hussain said:
> Re-sending. Previous patch I put in very old kernel-newbies address.
>
> Subject: [PATCH 1/1] staging: erofs: Add function comment for
>  erofs/super.c
>
> This patch adds functions comment for file erofs/super.c in
> sphinx format.
>
> Signed-off-by: Arshad Hussain <arshad.super@gmail.com>
> ---
>  drivers/staging/erofs/super.c | 133 ++++++++++++++++++++++++++++++++++++++++
+-
>  1 file changed, 130 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/erofs/super.c b/drivers/staging/erofs/super.c
> index 15c784fba879..6d2b93d94839 100644
> --- a/drivers/staging/erofs/super.c
> +++ b/drivers/staging/erofs/super.c
> @@ -30,6 +30,11 @@ static void init_once(void *ptr)
>         inode_init_once(&vi->vfs_inode);
>  }
>
> +/*

Actually, if you're trying to do sphinx/kerneldoc format, the first line of the
block comment should be '/**' with two asterisks.

Also, all kernel patches should be cc'd to linux-kernel@vger.kernel.org as well as
the maintainers and subsystem lists.


_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

  reply	other threads:[~2019-03-12 18:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 18:03 [PATCH 1/1] staging: erofs: Add function comment for erofs/super.c arshad hussain
2019-03-12 18:40 ` valdis.kletnieks [this message]
2019-03-12 19:01 ` Greg KH
2019-03-13  0:48 ` Gao Xiang
2019-03-13  6:41   ` valdis.kletnieks
2019-03-13  6:50     ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17926.1552416036@turing-police \
    --to=valdis.kletnieks@vt.edu \
    --cc=arshad.super@gmail.com \
    --cc=hsiangkao@aol.com \
    --cc=hsiangkao@gmx.com \
    --cc=kernelnewbies@kernelnewbies.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=miaoxie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).