kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: "B1C0D8C0 AACEC2D2D3CDC5CDCACE" <alexander198961@gmail.com>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernelnewbies@kernelnewbies.org
Subject: Re: Need advice about do we need this if condition
Date: Wed, 17 Apr 2019 03:56:33 -0400	[thread overview]
Message-ID: <19402.1555487793@turing-police> (raw)
In-Reply-To: <CANtEx+B4_-7Kfq6Gur1xHcXnTYRq8ZN=Qqs2X=h-ZJuFFF7LbQ@mail.gmail.com>

On Wed, 17 Apr 2019 08:25:22 +0300

(Adding Al Viro and the linux-fsdevel lists, as at the very least, the manpage
for the syscall needs some clarification...)

> hello I am trying to fix https://bugzilla.kernel.org/show_bug.cgi?id=202935

So - convince us that it's in fact a "bug" and not a restriction.

> I found cause
> https://github.com/torvalds/linux/blob/master/fs/cifs/cifsfs.c#L1076 not
> sure is it correct to remove such condition ?

Does the CIFS protocol support copying from a file to another location in the
same file? Was it intended to work on *any* filesystem?

(For that matter, the manpage for the syscall is unclear on whether having both
file descriptors open on the same file is OK or not - for bonus ambiguity
points, there's exactly zero discussion of what happens if source and
destination overlap destructively).


_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

  reply	other threads:[~2019-04-17  7:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17  5:25 Need advice about do we need this if condition Саша Ковтуненко
2019-04-17  7:56 ` Valdis Klētnieks [this message]
2019-04-17 13:32   ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19402.1555487793@turing-police \
    --to=valdis.kletnieks@vt.edu \
    --cc=alexander198961@gmail.com \
    --cc=kernelnewbies@kernelnewbies.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).