From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86759C10F12 for ; Wed, 17 Apr 2019 07:57:03 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4597B20835 for ; Wed, 17 Apr 2019 07:57:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4597B20835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vt.edu Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.91) (envelope-from ) id 1hGfQy-0005Vg-Cd; Wed, 17 Apr 2019 03:56:44 -0400 Received: from omr1.cc.ipv6.vt.edu ([2607:b400:92:8300:0:c6:2117:b0e] helo=omr1.cc.vt.edu) by shelob.surriel.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hGfQw-0005VZ-1J for kernelnewbies@kernelnewbies.org; Wed, 17 Apr 2019 03:56:42 -0400 Received: from mr5.cc.vt.edu (mr5.cc.vt.edu [IPv6:2607:b400:92:8400:0:72:232:758b]) by omr1.cc.vt.edu (8.14.4/8.14.4) with ESMTP id x3H7ue6e026961 for ; Wed, 17 Apr 2019 03:56:40 -0400 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mr5.cc.vt.edu (8.14.7/8.14.7) with ESMTP id x3H7uZE6001724 for ; Wed, 17 Apr 2019 03:56:40 -0400 Received: by mail-qk1-f200.google.com with SMTP id y64so20159106qka.3 for ; Wed, 17 Apr 2019 00:56:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:content-transfer-encoding:date:message-id; bh=XRal/KDUMxotBEJcVsOP5tkbeKLtAGY+Cmt6EWYQpMM=; b=OqxoLRXzvtKyvLoHSYEdK0aItUvR50qg7rYFqYzp8KsUm3qq7XPYrpU/YANwbTopIf BsBDrd6WHvq0OPddhoUnt+wofRtlA9y6SaFKtpgy6MaKb6dBxGoQuLxVSAdgJlu8uSmh jvAXBPRMz1X+vzz05w9OzJTosF9f3oDzi/OWkQZ0dbgXgBjG1H5W0Doc4zzGrI4x1wDs wSNGDLm0RkR150v5rY/QM8EUGsF3etYXDARho8bKSjc3Yg5szq5hEf8403WHKkt0Du6/ G8LKvqng3/7PkBSvqSj1wk/r0u/CiD62rZLyBXq8LZ7mtT7CO9EkZOHbiI0S3oRKrJFy S2aA== X-Gm-Message-State: APjAAAW55KZfbtFYRxRsSaCydyEgsZRB+bX4rCnb7F9C/aNEosAT1JXu 2tRmSkLY/OiXQ3rq0+UtXggmQiEATa48o6yTnaxIN4T4fw14ZMZpqt+F5Ohf9vpZZLVfyc1dLp8 cmPRXFF8o6A8hpkMcNUWEX+LlTfJlNJ5YT8ZSv1c= X-Received: by 2002:a0c:897b:: with SMTP id 56mr69182566qvq.55.1555487795564; Wed, 17 Apr 2019 00:56:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqx3ecN7jlhMZcM6t9DP1Pb6KVPvEg1Z5z9gv4RNYB7Cf+vCWGvu0HZ0lbB759a1mHlUIjeVrA== X-Received: by 2002:a0c:897b:: with SMTP id 56mr69182550qvq.55.1555487795257; Wed, 17 Apr 2019 00:56:35 -0700 (PDT) Received: from turing-police ([2601:5c0:c001:4341::1a7]) by smtp.gmail.com with ESMTPSA id y34sm35037616qta.96.2019.04.17.00.56.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Apr 2019 00:56:34 -0700 (PDT) From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: =?utf-8?Q?=421=430=448=430?= =?utf-8?Q?_=41A=43E=432=442=443=43D=435=43D=43A=43E?= , Alexander Viro Subject: Re: Need advice about do we need this if condition In-reply-to: References: Mime-Version: 1.0 Date: Wed, 17 Apr 2019 03:56:33 -0400 Message-ID: <19402.1555487793@turing-police> Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Wed, 17 Apr 2019 08:25:22 +0300 (Adding Al Viro and the linux-fsdevel lists, as at the very least, the manpage for the syscall needs some clarification...) > hello I am trying to fix https://bugzilla.kernel.org/show_bug.cgi?id=202935 So - convince us that it's in fact a "bug" and not a restriction. > I found cause > https://github.com/torvalds/linux/blob/master/fs/cifs/cifsfs.c#L1076 not > sure is it correct to remove such condition ? Does the CIFS protocol support copying from a file to another location in the same file? Was it intended to work on *any* filesystem? (For that matter, the manpage for the syscall is unclear on whether having both file descriptors open on the same file is OK or not - for bonus ambiguity points, there's exactly zero discussion of what happens if source and destination overlap destructively). _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies