From: Greg KH <greg@kroah.com>
To: Paulo Almeida <paulo.miguel.almeida.rodenas@gmail.com>
Cc: kernelnewbies@kernelnewbies.org
Subject: Re: Can't seem to find a maintainer for init/* files
Date: Fri, 18 Oct 2019 18:32:05 -0400 [thread overview]
Message-ID: <20191018223205.GC6978@kroah.com> (raw)
In-Reply-To: <CAMLg8QgejaXgeDH83wdCt_-VEE4w4a1wntwrs+UXiehfzSNWsA@mail.gmail.com>
On Sat, Oct 19, 2019 at 10:33:00AM +1300, Paulo Almeida wrote:
> Hi all,
>
> I was reading the KernelJanitor/Todo webpage and found the printk-related
> task that had to be done.
>
> I eventually came across this piece of code that led me to 2 questions that
> I couldn't answer myself
> https://github.com/torvalds/linux/blame/master/init/do_mounts.c#L434-L455
>
> 1 - This specific code block has been around for quite some time and many
> additions using the correct printk(KERN_* were made after it was written.
> Does that mean that this code block is an exception and should be left
> as-is for some technical reason? Or, people have somehow forgotten about it
> and I finally found something to do? :)
>
> 2 - I took a look at the https://www.kernel.org/doc/linux/MAINTAINERS list
> and their respective folders/repos and couldn't find out who would be the
> person who I should eventually send the patches to. Is there any
> "fallthrough" maintainer when there isn't one specified? (Please put me
> straight if I'm not seeing things from the right angle)
Run scripts/get_maintainer.pl on any file and it will tell you where to
send changes to:
$ ./scripts/get_maintainer.pl --file init/do_mounts.c
Al Viro <viro@zeniv.linux.org.uk> (commit_signer:7/9=78%,authored:5/9=56%,added_lines:7/44=16%,removed_lines:27/32=84%)
David Howells <dhowells@redhat.com> (commit_signer:3/9=33%,authored:2/9=22%,added_lines:5/44=11%,removed_lines:5/32=16%)
Andrew Morton <akpm@linux-foundation.org> (commit_signer:2/9=22%)
Nikolaus Voss <nikolaus.voss@loewensteinmedical.de> (commit_signer:1/9=11%,authored:1/9=11%,added_lines:31/44=70%)
Thomas Gleixner <tglx@linutronix.de> (commit_signer:1/9=11%,authored:1/9=11%)
linux-kernel@vger.kernel.org (open list)
But don't do janitorial cleanup on those files as a "first task". That
is what the drivers/staging/ directory is for, don't mess with core
kernel files unless you have experience doing kernel changes, as the
learning curve needs to be gotten over first.
good luck!
greg k-h
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2019-10-18 22:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 21:33 Can't seem to find a maintainer for init/* files Paulo Almeida
2019-10-18 21:38 ` Paulo Almeida
2019-10-18 22:32 ` Greg KH [this message]
2019-10-18 23:53 ` Paulo Almeida
2019-10-18 23:25 ` Valdis Klētnieks
2019-10-21 12:37 ` Paulo Miguel Almeida
2019-10-21 13:45 ` Valdis Klētnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018223205.GC6978@kroah.com \
--to=greg@kroah.com \
--cc=kernelnewbies@kernelnewbies.org \
--cc=paulo.miguel.almeida.rodenas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).