From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FF88C33CAB for ; Mon, 13 Jan 2020 05:03:33 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A69F21744 for ; Mon, 13 Jan 2020 05:03:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nV0ebd/I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A69F21744 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.92.3) (envelope-from ) id 1iqrsR-0002wr-Hv; Mon, 13 Jan 2020 00:02:59 -0500 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by shelob.surriel.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.3) (envelope-from ) id 1iqrsP-0002wl-Ez for kernelnewbies@kernelnewbies.org; Mon, 13 Jan 2020 00:02:57 -0500 Received: by mail-pj1-x1043.google.com with SMTP id s7so3744264pjc.0 for ; Sun, 12 Jan 2020 21:02:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mail-followup-to:mime-version :content-disposition; bh=SY0jokrVDQcVze3LIZ3UVJ+BmZqNGjnEs8v301a9z+g=; b=nV0ebd/IU6DN9bYEQq6rWCLxknlwCthKSsn8y1TphpSPYzM5Y6WY5s5EZBTLLtgHB0 oD1zs36ja0iXGvLYypKeKl/41HCkmc60V9D+X/r++f1MIxBDZU5geUydug1H2rPohLih oZrbQ0Ys4CeNn9gHOQAJ9RX9h8JndSYki1leVurL6iiZmP8KA5DQx4WU0R4Ex0C2U/xb Ef15rWFV2iVZAvlSeX12TzHPzAawFPhLWQafB1RSwTjEgYdUb1iz76dRjLQLqGo6LCic 8bZSnxBuOrs+cwTof2j8utlMpu/nbO6KCCbtYilsC2zAG/zORNpbV0P5Iqq+3zW7lraP guWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :mime-version:content-disposition; bh=SY0jokrVDQcVze3LIZ3UVJ+BmZqNGjnEs8v301a9z+g=; b=EDI4R/W5QN1tNMzx59HuoNOl/eTqQL2a7ilzwi9qsrTJC8FOzoxEjw36HSgyim1VmU 9MC3s+iTCGBfxJMMbHsOo4x9DDBTlWDbAVffoK6rQ9Mjr7eCwel85r12gM2qXFe/1Bhf /glaVZ0sT4UJEpfmRGPiHTY1YRJdwtHz20rbY3DdFNWxNrsjn7uydHJG/bN6YIh5Erx5 8NduLR4E8vwXPOK6KyUCKzwMx+WLd+fQMBGHR9KGpntESx/kD9gE+tHc1pl1S0f80Ck0 qQi7Mj4GDDfSY/tB1z1L19ej6h/NXdTPHi0h5ta9aALA9RF8jWbV8bd0Kvsxh45gDIIk gnxw== X-Gm-Message-State: APjAAAVhWXmQ8yxjWh99ES3/7XRKqCfhNVK/FFpF0UBf5oHr1kxSaLdY TNHaXcrY2thWFcom1mJY956dyPPzQxg= X-Google-Smtp-Source: APXvYqwOCUfbbE7UHV0hIkUBjLGmB6G9h8FaL6KUxcvjw6uywFT4jMIpmlWZ7A9MaBXpdz6cFwXxWA== X-Received: by 2002:a17:902:bd06:: with SMTP id p6mr12505644pls.27.1578891771450; Sun, 12 Jan 2020 21:02:51 -0800 (PST) Received: from localhost.localdomain (125-237-41-215-adsl.sparkbb.co.nz. [125.237.41.215]) by smtp.gmail.com with ESMTPSA id i4sm11493984pgc.51.2020.01.12.21.02.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jan 2020 21:02:50 -0800 (PST) Date: Mon, 13 Jan 2020 18:02:47 +1300 From: Paulo Miguel Almeida To: kernelnewbies@kernelnewbies.org Subject: [PATCH] staging: rtl8192u: specify printk's KERN_ in ieee80211 Message-ID: <20200113050247.GA318164@localhost.localdomain> Mail-Followup-To: Paulo Miguel Almeida , kernelnewbies@kernelnewbies.org MIME-Version: 1.0 Content-Disposition: inline X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org Hi, I'm planning to submit this cleanup patch but I would appreciate if some of you could consider reviewing it first as this is my first patch. Also, when it comes to whom to send it to, this is the list I got so far but please let me know if I should either add or exclude anyone from this list so that I send this patch to the right people while not spamming others. ./scripts/get_maintainer.pl /tmp/0001-staging-rtl8192u-specify-printk-s-KERN_-LEVEL-in-iee.patch Greg Kroah-Hartman (supporter:STAGING SUBSYSTEM,commit_signer:17/18=94%) Puranjay Mohan (commit_signer:4/18=22%,authored:4/18=22%) Stephen Brennan (commit_signer:4/18=22%,authored:4/18=22%,added_lines:297/366=81%,removed_lines:388/470=83%) Bhanusree Pola (commit_signer:3/18=17%,authored:3/18=17%) Sanjana Sanikommu (commit_signer:2/18=11%,authored:2/18=11%) Vatsala Narang (authored:1/18=6%) devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM) linux-kernel@vger.kernel.org (open list) The origin commit message follows Checkpatch reports 'WARNING: printk() should include KERN_ facility level'. Fix this by specifying a relevant KERN_ value for each line in which it was missing. Signed-off-by: Paulo Miguel Almeida --- .../staging/rtl8192u/ieee80211/ieee80211_rx.c | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c index 00fea127bdc3..f38986d74005 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c @@ -810,11 +810,11 @@ static u8 parse_subframe(struct sk_buff *skb, nSubframe_Length = (nSubframe_Length >> 8) + (nSubframe_Length << 8); if (skb->len < (ETHERNET_HEADER_SIZE + nSubframe_Length)) { - printk("%s: A-MSDU parse error!! pRfd->nTotalSubframe : %d\n",\ + printk(KERN_DEBUG "%s: A-MSDU parse error!! pRfd->nTotalSubframe : %d\n", __func__, rxb->nr_subframes); - printk("%s: A-MSDU parse error!! Subframe Length: %d\n", __func__, nSubframe_Length); - printk("nRemain_Length is %d and nSubframe_Length is : %d\n", skb->len, nSubframe_Length); - printk("The Packet SeqNum is %d\n", SeqNum); + printk(KERN_DEBUG "%s: A-MSDU parse error!! Subframe Length: %d\n", __func__, nSubframe_Length); + printk(KERN_DEBUG "nRemain_Length is %d and nSubframe_Length is : %d\n", skb->len, nSubframe_Length); + printk(KERN_DEBUG "The Packet SeqNum is %d\n", SeqNum); return 0; } @@ -919,7 +919,7 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct sk_buff *skb, if (HTCCheck(ieee, skb->data)) { if (net_ratelimit()) - printk("find HTCControl\n"); + printk(KERN_WARNING "find HTCControl\n"); hdrlen += 4; rx_stats->bContainHTC = true; } @@ -1113,7 +1113,7 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct sk_buff *skb, if (ieee->host_decrypt && (fc & IEEE80211_FCTL_WEP) && (keyidx = ieee80211_rx_frame_decrypt(ieee, skb, crypt)) < 0) { - printk("decrypt frame error\n"); + printk(KERN_WARNING "decrypt frame error\n"); goto rx_dropped; } @@ -1178,7 +1178,7 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct sk_buff *skb, * encrypted/authenticated */ if (ieee->host_decrypt && (fc & IEEE80211_FCTL_WEP) && ieee80211_rx_frame_decrypt_msdu(ieee, skb, keyidx, crypt)) { - printk("==>decrypt msdu error\n"); + printk(KERN_WARNING "==>decrypt msdu error\n"); goto rx_dropped; } @@ -1863,7 +1863,7 @@ int ieee80211_parse_info_param(struct ieee80211_device *ieee, info_element->data[0] == 0x00 && info_element->data[1] == 0x13 && info_element->data[2] == 0x74)) { - printk("========>%s(): athros AP is exist\n", __func__); + printk(KERN_DEBUG "========>%s(): athros AP is exist\n", __func__); network->atheros_cap_exist = true; } else network->atheros_cap_exist = false; @@ -2357,14 +2357,14 @@ static inline void ieee80211_process_probe_response( if (IS_COUNTRY_IE_VALID(ieee)) { // Case 1: Country code if (!is_legal_channel(ieee, network->channel)) { - printk("GetScanInfo(): For Country code, filter probe response at channel(%d).\n", network->channel); + printk(KERN_WARNING "GetScanInfo(): For Country code, filter probe response at channel(%d).\n", network->channel); goto out; } } else { // Case 2: No any country code. // Filter over channel ch12~14 if (network->channel > 11) { - printk("GetScanInfo(): For Global Domain, filter probe response at channel(%d).\n", network->channel); + printk(KERN_WARNING "GetScanInfo(): For Global Domain, filter probe response at channel(%d).\n", network->channel); goto out; } } @@ -2372,14 +2372,14 @@ static inline void ieee80211_process_probe_response( if (IS_COUNTRY_IE_VALID(ieee)) { // Case 1: Country code if (!is_legal_channel(ieee, network->channel)) { - printk("GetScanInfo(): For Country code, filter beacon at channel(%d).\n", network->channel); + printk(KERN_WARNING "GetScanInfo(): For Country code, filter beacon at channel(%d).\n", network->channel); goto out; } } else { // Case 2: No any country code. // Filter over channel ch12~14 if (network->channel > 14) { - printk("GetScanInfo(): For Global Domain, filter beacon at channel(%d).\n", network->channel); + printk(KERN_WARNING "GetScanInfo(): For Global Domain, filter beacon at channel(%d).\n", network->channel); goto out; } } -- 2.24.1 _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies