From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D465C33CAB for ; Mon, 13 Jan 2020 08:30:43 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F94D214D8 for ; Mon, 13 Jan 2020 08:30:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F94D214D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.92.3) (envelope-from ) id 1iqv6m-00068M-Se; Mon, 13 Jan 2020 03:30:00 -0500 Received: from mail.kernel.org ([198.145.29.99]) by shelob.surriel.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1iqv6l-00068F-BM for kernelnewbies@kernelnewbies.org; Mon, 13 Jan 2020 03:29:59 -0500 Received: from localhost (unknown [84.241.201.167]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 918B8214D8; Mon, 13 Jan 2020 08:29:55 +0000 (UTC) Date: Mon, 13 Jan 2020 09:29:53 +0100 From: Greg KH To: Paulo Miguel Almeida , kernelnewbies@kernelnewbies.org Subject: Re: [PATCH] staging: rtl8192u: specify printk's KERN_ in ieee80211 Message-ID: <20200113082953.GA2097198@kroah.com> References: <20200113050247.GA318164@localhost.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200113050247.GA318164@localhost.localdomain> X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Mon, Jan 13, 2020 at 06:02:47PM +1300, Paulo Miguel Almeida wrote: > Hi, > > I'm planning to submit this cleanup patch but I would appreciate if some > of you could consider reviewing it first as this is my first patch. > > Also, when it comes to whom to send it to, this is the list I got so far but > please let me know if I should either add or exclude anyone from this > list so that I send this patch to the right people while not spamming others. > > ./scripts/get_maintainer.pl /tmp/0001-staging-rtl8192u-specify-printk-s-KERN_-LEVEL-in-iee.patch > Greg Kroah-Hartman (supporter:STAGING SUBSYSTEM,commit_signer:17/18=94%) > Puranjay Mohan (commit_signer:4/18=22%,authored:4/18=22%) > Stephen Brennan (commit_signer:4/18=22%,authored:4/18=22%,added_lines:297/366=81%,removed_lines:388/470=83%) > Bhanusree Pola (commit_signer:3/18=17%,authored:3/18=17%) > Sanjana Sanikommu (commit_signer:2/18=11%,authored:2/18=11%) > Vatsala Narang (authored:1/18=6%) > devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM) > linux-kernel@vger.kernel.org (open list) Looks correct. > The origin commit message follows > > Checkpatch reports 'WARNING: printk() should include KERN_ > facility level'. Fix this by specifying a relevant KERN_ value > for each line in which it was missing. > > Signed-off-by: Paulo Miguel Almeida > --- > .../staging/rtl8192u/ieee80211/ieee80211_rx.c | 24 +++++++++---------- > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c > index 00fea127bdc3..f38986d74005 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c > @@ -810,11 +810,11 @@ static u8 parse_subframe(struct sk_buff *skb, > nSubframe_Length = (nSubframe_Length >> 8) + (nSubframe_Length << 8); > > if (skb->len < (ETHERNET_HEADER_SIZE + nSubframe_Length)) { > - printk("%s: A-MSDU parse error!! pRfd->nTotalSubframe : %d\n",\ > + printk(KERN_DEBUG "%s: A-MSDU parse error!! pRfd->nTotalSubframe : %d\n", > __func__, rxb->nr_subframes); > - printk("%s: A-MSDU parse error!! Subframe Length: %d\n", __func__, nSubframe_Length); > - printk("nRemain_Length is %d and nSubframe_Length is : %d\n", skb->len, nSubframe_Length); > - printk("The Packet SeqNum is %d\n", SeqNum); > + printk(KERN_DEBUG "%s: A-MSDU parse error!! Subframe Length: %d\n", __func__, nSubframe_Length); > + printk(KERN_DEBUG "nRemain_Length is %d and nSubframe_Length is : %d\n", skb->len, nSubframe_Length); > + printk(KERN_DEBUG "The Packet SeqNum is %d\n", SeqNum); As this is a driver, you really should be using dev_dbg() for this, or better yet, netdev_dbg() as I think checkpatch will ask you to do. Same for all of the other conversions in this file, try using a "better" thing than printk. But you are on the right track, nice job. thanks, greg k-h _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies