From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F1EC43331 for ; Wed, 25 Mar 2020 09:51:57 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 621E820772 for ; Wed, 25 Mar 2020 09:51:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="nhzmQENP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="nOtVvamZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 621E820772 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.92.3) (envelope-from ) id 1jH2hD-0004bx-TV; Wed, 25 Mar 2020 05:51:35 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by shelob.surriel.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1jH2hB-0004br-Nn for kernelnewbies@kernelnewbies.org; Wed, 25 Mar 2020 05:51:34 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1CD445C02F4; Wed, 25 Mar 2020 05:51:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 25 Mar 2020 05:51:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=EaGXUzk6DFzpAkBQVVpCvHzIsE8 33okgKqCGPKsk7rQ=; b=nhzmQENP4Gm4I+T8jNdOgoV1T70eBqVKCKV1vEd4mSM UuNzu5a7fvRjOJPVNyxnQQcasiopb42rNx/Fq3jxWHqCXwj3t+Wp26QWzYyz5cuB iA1lpC0o4PSBXx+YydC+wi6VH3BTBuRpmyOSIcX2cxSleDbxK4j/i7pKNeLrNav7 hUyx2qsy+mRHVZlA060ayM5Y/7ITP2yXfmEojQFull5eNqmDMKwczDVLYlLJcgh4 GFCGcGD5LD2Zgzo4zuNB9ZMXEAtfF71owpb5IRs/jr6xiZzLOy/E1LEGTE9aB/K8 mg7Q4csie3/Be7JmrQxfkC84Rhv5o6mbIM+3ifkGTGw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=EaGXUz k6DFzpAkBQVVpCvHzIsE833okgKqCGPKsk7rQ=; b=nOtVvamZoMwRECeMZMTMM6 hg9Oc3hwKdcEOLwX06YAvqDaonUHNr3dSrU8i8ZhYghWKahZdbhdW4sAVy18xa7+ b9TPhEAstBiB6KVzE3tIp7Xpyb9zTtWecYkahutovs2QmJf1ejhP7jX2LRkoMzsk 9UMfqTaF8s9H1CRtluk8VtRXDRnmujGGzMint4hXrThcEG4cCLZCkkp5yNakdKYD 19f6J2VbUDT4HzsTC4zO7bGi01a0ngxKKhnlVv5cmaypRRK9t/xBTlHz9SzdZHv1 CTwqb42flS4ieN6/XH+XktULea9/AEX6T0Jwiac6ESCVzbAYMwTuqudkfcvEDmdg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudehfedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkphepkeefrdekiedrkeelrddutd ejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhr vghgsehkrhhorghhrdgtohhm X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 402153280068; Wed, 25 Mar 2020 05:51:29 -0400 (EDT) Date: Wed, 25 Mar 2020 10:51:26 +0100 From: Greg KH To: Tomek The Messenger Subject: Re: linux kernel coding style and checkpatch.pl script Message-ID: <20200325095126.GA3081597@kroah.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Wed, Mar 25, 2020 at 10:36:08AM +0100, Tomek The Messenger wrote: > Hi > There is checkpatch.pl script where You can check if You wrote code in your > kernel module according to linux kernel style. > However can I ignore warning message? > WARNING: quoted string split across lines > #974: FILE: fpgax67-core.c:974: > + dev_err(&pdev->dev, "registration not done, driver is > already " > + "registered\n"); > > If I don't split line I will have another warning that 80 characters is > exceeded. No you should not. > For sure I can ignore warnings about: > WARNING: struct should normally be const > #998: FILE: fpgax67-core.c :998: > +int fpgax67_unregister(struct platform_device *pdev) No, please do not. > For sure all errors must be fixed like: > const char* tmp -> change to -> const char *tmp; > if( => if ( #insert space Yes. > Generally I don't know how much warnings should I correct. If it is > mandatory or only good practise and I can omit some if it doesn't make > sense. If you want your code merged properly, and reviewed, just fix them all, should not take more than a few hours. good luck! greg k-h _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies