From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=OGdS=55=kernelnewbies.org=kernelnewbies-bounces@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 26676C2BA19
	for <kernelnewbies@archiver.kernel.org>; Mon, 13 Apr 2020 17:16:51 +0000 (UTC)
Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id C111920739
	for <kernelnewbies@archiver.kernel.org>; Mon, 13 Apr 2020 17:16:50 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C111920739
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hofr.at
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org
Received: from localhost ([::1] helo=shelob.surriel.com)
	by shelob.surriel.com with esmtp (Exim 4.92.3)
	(envelope-from <kernelnewbies-bounces@kernelnewbies.org>)
	id 1jO2gx-00027k-LP; Mon, 13 Apr 2020 13:16:15 -0400
Received: from 178.115.242.59.static.drei.at ([178.115.242.59]
 helo=mail.osadl.at) by shelob.surriel.com with esmtp (Exim 4.92.3)
 (envelope-from <hofrat@osadl.at>) id 1jO2gv-00027d-7J
 for kernelnewbies@kernelnewbies.org; Mon, 13 Apr 2020 13:16:13 -0400
Received: by mail.osadl.at (Postfix, from userid 1001)
 id 0F7455C0321; Mon, 13 Apr 2020 19:15:17 +0200 (CEST)
Date: Mon, 13 Apr 2020 19:15:17 +0200
From: Nicholas Mc Guire <der.herr@hofr.at>
To: Kernel Newbies <kernelnewbies@kernelnewbies.org>
Subject: Fixes tag confusion
Message-ID: <20200413171516.GB16616@osadl.at>
MIME-Version: 1.0
Content-Disposition: inline
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: kernelnewbies@kernelnewbies.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Learn about the Linux kernel <kernelnewbies.kernelnewbies.org>
List-Unsubscribe: <https://lists.kernelnewbies.org/mailman/options/kernelnewbies>, 
 <mailto:kernelnewbies-request@kernelnewbies.org?subject=unsubscribe>
List-Archive: <http://lists.kernelnewbies.org/pipermail/kernelnewbies/>
List-Post: <mailto:kernelnewbies@kernelnewbies.org>
List-Help: <mailto:kernelnewbies-request@kernelnewbies.org?subject=help>
List-Subscribe: <https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies>, 
 <mailto:kernelnewbies-request@kernelnewbies.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: kernelnewbies-bounces@kernelnewbies.org


Hi !

 Looking at some of the fixes tags in linux-stable e.g.

commit 27d231c0c63b -> :pnfs_alloc_ds_commits_list:fs/nfs/pnfs_nfs.c 
Fixes: a9901899b649

 inspecting the history of this function shows

linux-stable$ git log  -L:pnfs_alloc_ds_commits_list:fs/nfs/pnfs_nfs.c | grep "^commit "
commit 27d231c0c63bb619997a24bab85d54d90ca71110
commit a9901899b649dc80ef75c14d6d78059cae14def7
commit 0cb1f6df8a63b51f276f94d94957d7a7ca757667
commit f54bcf2ecee982da47c2baf8bd87fd9ad9984651

 or:

commit 9b8b17541f13
Fixes: e26733e0d0ec

 gives me:

linux-stable$ git log -L:calculate_high_delay:mm/memcontrol.c | grep "^commit "
commit 9b8b17541f13809d06f6f873325305ddbb760e3e
commit e26733e0d0ec6798eca93daa300bc3f43616127f
commit d397a45fc741c80c32a14e2de008441e9976f50c
commit 0e4b01df865935007bd712cbc8e7299005b28894
commit f7e1cb6ec51b041335b5ad4dd7aefb37a56d79a6
commit b23afb93d317c65cef553b804f08dec8a7a0f7e1
 
 the initial bug introducing commit and the fix commit are visible
 But then there are other cases like:

commit 26c5d78c976c which fixed up get_fs_type in fs/filesystems.c 
Fixes: 41124db869b7

commit 26c5d78c976c
<snip>
-               WARN_ONCE(!fs, "request_module fs-%.*s succeeded, but still no fs?\n", len, name);
+               if (!fs)
+                       pr_warn_once("request_module fs-%.*s succeeded, but still no fs?\n",
+                                    len, name);
<snip>
Fixes: 41124db869b7
<snip>
-       if (!fs && (request_module("fs-%.*s", len, name) == 0))
+       if (!fs && (request_module("fs-%.*s", len, name) == 0)) {
                fs = __get_fs_type(name, len);
+               WARN_ONCE(!fs, "request_module fs-%.*s succeeded, but still no fs?\n", len, name);
+       }
<snip>

 which seem to be correct - but git log does not display them ?

linux-stable$ git log -L:get_fs_type:fs/filesystems.c | grep "^commit "
commit d8e9650dff48055057253ca30933605bd7d0733b
commit 79c0b2df79eb56fc71e54c75cd7fb3acf84370f9
commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
 
 I see neither of the fix nor the fixed commit ? 
 This is on a Debian 10.3 with git version 2.20.1

 It does not seem to be a rename issue - so I'm a bit lost on this one
 Is this a wrong expectation on my side - or am I using git in some wrong way here ?

thx!
hofrat

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies