From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38E3BC47247 for ; Tue, 5 May 2020 18:07:00 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D52A0206FA for ; Tue, 5 May 2020 18:06:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="esgqXfTS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="vBEt1KKM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D52A0206FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.92.3) (envelope-from ) id 1jW1x2-0007nr-5q; Tue, 05 May 2020 14:05:52 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by shelob.surriel.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1jW1wz-0007nk-9F for kernelnewbies@kernelnewbies.org; Tue, 05 May 2020 14:05:49 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 8F25E978; Tue, 5 May 2020 14:05:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 05 May 2020 14:05:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=R/dsTGm9FXzL3CiuN2PWjEgTWhe 51bjZWbKDqVwPINA=; b=esgqXfTSVE1HT3eI8f58ZMjMgi6bzXYRnrFV+DkTOq6 /0TY230sCK2Et3+wIrWkTo0tSCkjrFCNeDvTyv7YiawE2D3gaMVWgTiLJE9Yz9Fc TVa7r5Xu4P3WiYSCHCd3DQA+anE+6Ob4QKB5BMJ64KtBRz+AvWQ3DK/9XGJiJB5k 8AwX6nc2+jbt0YVjRtZ8etuQMLSJ2JoVlM275GWN7WXzgdCAwx/Eh+Si9U5SfNwG fMKSe00sm/JSSpYHKFf4iE8/QjbTiuh50Hkrq+NGq2QGPLdRZ1UxdQ2DDuQHJEPy bY7eS/WyuPl6yyqCkbV2nFajK71Ot/kCqFsvPHjvIGg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=R/dsTG m9FXzL3CiuN2PWjEgTWhe51bjZWbKDqVwPINA=; b=vBEt1KKMyM8J+ynQlDVkbs PO4brXUcPUKrbQxKTFpP7xNQBs6/lqOb9rXeOh3QCb3fTpwPPNetiQLeTW8vckXS PSmImtIc1YS5WGU4bQBe1ypqKggujkRlB31oEApxnfh3zOoXRIUecLXnHAbFHmZQ Hv/zoMsGQet6ZsmN8zdwynoCFzGZcK2HnLyDw5N4Vdt78Sv5TbFBehzj3/PBuz3L HmSl8YXJtH110+9ZSv23b6EDa+O4MkP5eDLGW64vn28+9CJBKtw3Nqj6evR06BNB yW4IMm4ynmZEPX7mjlwLv1QKfNst0QplypUalTUlLp2n0flCE7MoqPI7BMpPO2TQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrjeeigdduudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepifhrvghgucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheq necuggftrfgrthhtvghrnhepveeuheejgfffgfeivddukedvkedtleelleeghfeljeeiue eggeevueduudekvdetnecukfhppeekfedrkeeirdekledruddtjeenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtg homh X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 4149D30660C5; Tue, 5 May 2020 14:05:41 -0400 (EDT) Date: Tue, 5 May 2020 20:05:36 +0200 From: Greg KH To: Jacko Dirks Subject: Re: Location of files for a new driver Message-ID: <20200505180536.GC1199718@kroah.com> References: <20200505135828.GA466217@vasteMachine> <20200505142032.GA793696@kroah.com> <20200505143806.GA589943@vasteMachine> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200505143806.GA589943@vasteMachine> Cc: kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Tue, May 05, 2020 at 04:38:06PM +0200, Jacko Dirks wrote: > On Tue, May 05, 2020 at 04:20:32PM +0200, Greg KH wrote: > > drivers/staging/ is only for code that needs lots and lots of work to > > get into the "real" part of the kernel. It also requires a TODO file > > that lists what is left to do to get it out of that location. > > Oh, I did not know that staging was optional. Well, I will attempt to > skip staging in that case Please do :) > > It all depends on what you are writing. What exactly does this code do? > > That will determine where it goes in the kernel tree. > > The code is a driver for the Broadcom BSC, which lives on the Raspberry > Pi 3 & 4 (at least, maybe also on 1 & 2). This device can act as an I2C > slave. To "announce" the device (tell the device tree which pins need to > be configured how, etcetera) I need to change existing dts/dtsi files, > to actually be able to enable the device I need to create a new overlay. > Finally, the actual driver needs to be created in drivers/i2c/busses. And > then there is also some makefile, documentation and kconfig. > > Does that sound right? Sounds correct to me. It's easy to move files around if you make up a patch and submit it to the mailing lists and people tell you to do so. The harder part is writing a driver that works :) good luck! greg k-h _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies