Kernel Newbies archive on lore.kernel.org
 help / color / Atom feed
* Where to place my driver
@ 2020-06-23 20:26 jaap aarts
  2020-06-30  6:13 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: jaap aarts @ 2020-06-23 20:26 UTC (permalink / raw)
  To: kernelnewbies

Hello kernel newbies,

I am currently writing a driver for asetek 6th gen CPU coolers.
Communication to these coolers goes via USB, but 3/4 (but not all!!)
metrics are hwmon metrics.
There is a case for either USB or hwmon but I don't know where I am
supposed to put my driver.
There is also the 1/4, RGB controls, these obviously don't fit in
hwmon, but I don't know where to put these kinds of controls in the
filesystem.
If anyone could help me with these 2 choices I can start submitting my
first code (I already have fan control working).

Thanks,

Jaap Aarts

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Where to place my driver
  2020-06-23 20:26 Where to place my driver jaap aarts
@ 2020-06-30  6:13 ` Greg KH
  2020-07-01 10:42   ` jaap aarts
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2020-06-30  6:13 UTC (permalink / raw)
  To: jaap aarts; +Cc: kernelnewbies

On Tue, Jun 23, 2020 at 10:26:33PM +0200, jaap aarts wrote:
> Hello kernel newbies,
> 
> I am currently writing a driver for asetek 6th gen CPU coolers.
> Communication to these coolers goes via USB, but 3/4 (but not all!!)
> metrics are hwmon metrics.
> There is a case for either USB or hwmon but I don't know where I am
> supposed to put my driver.
> There is also the 1/4, RGB controls, these obviously don't fit in
> hwmon, but I don't know where to put these kinds of controls in the
> filesystem.

So those tie into the led subsystem?

> If anyone could help me with these 2 choices I can start submitting my
> first code (I already have fan control working).

start with drivers/hwmon/ and if the developers there don't think that
it should be there, let them tell you where to put it :)

Also, when submitting the driver, as it talks USB, be sure to cc: the
linux-usb@vger.kernel.org mailing list to get those driver author's
review.

good luck!

greg k-h

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Where to place my driver
  2020-06-30  6:13 ` Greg KH
@ 2020-07-01 10:42   ` jaap aarts
  0 siblings, 0 replies; 3+ messages in thread
From: jaap aarts @ 2020-07-01 10:42 UTC (permalink / raw)
  To: Greg KH; +Cc: kernelnewbies

> So those tie into the led subsystem?
OK I did not expect that to be a thing, seems like that is what I need.

> start with drivers/hwmon/ and if the developers there don't think that
> it should be there, let them tell you where to put it :)
I will be on holiday until end of next week, I will send in the first 3 patches
for fan support when I'm back home.
I will add temps and LED later on.
Maybe I will also add fan/pump speed curve, maybe.

Thanks :)

Jaap Aarts

On Tue, 30 Jun 2020 at 08:13, Greg KH <greg@kroah.com> wrote:
>
> On Tue, Jun 23, 2020 at 10:26:33PM +0200, jaap aarts wrote:
> > Hello kernel newbies,
> >
> > I am currently writing a driver for asetek 6th gen CPU coolers.
> > Communication to these coolers goes via USB, but 3/4 (but not all!!)
> > metrics are hwmon metrics.
> > There is a case for either USB or hwmon but I don't know where I am
> > supposed to put my driver.
> > There is also the 1/4, RGB controls, these obviously don't fit in
> > hwmon, but I don't know where to put these kinds of controls in the
> > filesystem.
>
> So those tie into the led subsystem?
>
> > If anyone could help me with these 2 choices I can start submitting my
> > first code (I already have fan control working).
>
> start with drivers/hwmon/ and if the developers there don't think that
> it should be there, let them tell you where to put it :)
>
> Also, when submitting the driver, as it talks USB, be sure to cc: the
> linux-usb@vger.kernel.org mailing list to get those driver author's
> review.
>
> good luck!
>
> greg k-h

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-23 20:26 Where to place my driver jaap aarts
2020-06-30  6:13 ` Greg KH
2020-07-01 10:42   ` jaap aarts

Kernel Newbies archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kernelnewbies/0 kernelnewbies/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kernelnewbies kernelnewbies/ https://lore.kernel.org/kernelnewbies \
		kernelnewbies@kernelnewbies.org
	public-inbox-index kernelnewbies

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernelnewbies.kernelnewbies


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git