From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C34FFC433E0 for ; Tue, 30 Jun 2020 06:13:59 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 734BC20759 for ; Tue, 30 Jun 2020 06:13:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="Zm9rhhX9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="feHi0yVG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 734BC20759 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94) (envelope-from ) id 1jq9W7-00016t-CN; Tue, 30 Jun 2020 02:13:15 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1jq9W3-00016k-Ei for kernelnewbies@kernelnewbies.org; Tue, 30 Jun 2020 02:13:12 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4E22C7B1; Tue, 30 Jun 2020 02:13:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 30 Jun 2020 02:13:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=sUQwjFLi4VSIPlWCYrJE9UrOYdP 6/oHacKFLMACywZM=; b=Zm9rhhX9v7+KhuIJq5Xq5fvXsHJwJWovy5gAnTbpIdk Y8Vs4By4L3nte9i9OCNMp1frXvzNoOO+87k1LuCmTcuY/OVG01yTqUgCDi7W7ona 5niif6hoH1b1kgJNllMBYTD5ce2ql9DiKtmDGfiWTiGp29MhjeI2q8POBHRBg90k Z6mIUtVz21rFMG92CdiQeU9/FIIKOe6yK7YqakXUxju9B5mI9xIaLh0x6TRv1r3l 15M5eYETW6WGeZwRB77tGWXBGMkgdKzrHUoHq0D/SQJ3NXbGIVJ0hDcswBt//tHC z7zTlpekaq1be5LPviqwJzXoYZldye1rHVcJ26jn8DQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=sUQwjF Li4VSIPlWCYrJE9UrOYdP6/oHacKFLMACywZM=; b=feHi0yVG8524nynx7b+q60 bhNuvXouHjUNaJG/v6ojEzTEuwflN5sTF6CxGxO+WWE6GJ3JaiW+bxdn2ez7imaU vyFUqzSSlQpDOqMYz6TWevRVXYwWaE2f7EXqyyR1qTwr2ovHfEpDL1ZoYx1wpOgU bsYsvlPlHvUyOIoTKSr987R7rJJGOzqis9h/CZDb7m/ftjTm/+AFU9JpSdd9Z+fb jW6IQG9yVlaMelbrqPJBUhydzVHvh0K6hHsCpDMddAnCLigG3uBXXJTMHQiRPmKF VS5YcBa6F/gmSVd7wd+9m72t7if1Qc5AXWPtPeBdKKHvjzICXixv/Hs5QTQI8DdA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrvddttddguddtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuhe ejgfffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecukfhppeek fedrkeeirdekledruddtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 6D59D3280060; Tue, 30 Jun 2020 02:13:05 -0400 (EDT) Date: Tue, 30 Jun 2020 08:13:03 +0200 From: Greg KH To: jaap aarts Subject: Re: Where to place my driver Message-ID: <20200630061303.GB616711@kroah.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Tue, Jun 23, 2020 at 10:26:33PM +0200, jaap aarts wrote: > Hello kernel newbies, > > I am currently writing a driver for asetek 6th gen CPU coolers. > Communication to these coolers goes via USB, but 3/4 (but not all!!) > metrics are hwmon metrics. > There is a case for either USB or hwmon but I don't know where I am > supposed to put my driver. > There is also the 1/4, RGB controls, these obviously don't fit in > hwmon, but I don't know where to put these kinds of controls in the > filesystem. So those tie into the led subsystem? > If anyone could help me with these 2 choices I can start submitting my > first code (I already have fan control working). start with drivers/hwmon/ and if the developers there don't think that it should be there, let them tell you where to put it :) Also, when submitting the driver, as it talks USB, be sure to cc: the linux-usb@vger.kernel.org mailing list to get those driver author's review. good luck! greg k-h _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies