Kernel Newbies Archive on lore.kernel.org
 help / color / Atom feed
* Confused about which branch to patch against
@ 2020-09-23  2:08 James Browning
  2020-09-23  2:28 ` James Browning
  2020-09-23  2:39 ` Gustavo A. R. Silva
  0 siblings, 2 replies; 5+ messages in thread
From: James Browning @ 2020-09-23  2:08 UTC (permalink / raw)
  To: kernelnewbies; +Cc: jamesbrowning137

Hi all,

After reading through the kernel documentation about submitting pathces,
and reading through the kernel newbies guide to submitting patches, I
still have some confusion.

Should I be doing all of my patching against linux-next as opposed to
the mainline tree? I tried submitting a patch to some typos I found on
the mainline tree, but they were rejected because they had already been
fixed in linux-next. 

I guess I dont really understand what patches become part of the next
mainline rc-x tree, and which patches become part of linux-next (which
from what I understand, doesn't get merged until the next merge window when the current kernel version is finished being stabalized).

Also, if I patch something in the linux-next tree, do I need to specify
which tree it is when I send the patch the maintainers?

Thank you for your help,
James Browning

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Confused about which branch to patch against
  2020-09-23  2:08 Confused about which branch to patch against James Browning
@ 2020-09-23  2:28 ` James Browning
  2020-09-23  2:39 ` Gustavo A. R. Silva
  1 sibling, 0 replies; 5+ messages in thread
From: James Browning @ 2020-09-23  2:28 UTC (permalink / raw)
  To: kernelnewbies; +Cc: jamesbrowning137

My subject line contains a typo. I meant to say "tree" not "branch"

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Confused about which branch to patch against
  2020-09-23  2:08 Confused about which branch to patch against James Browning
  2020-09-23  2:28 ` James Browning
@ 2020-09-23  2:39 ` Gustavo A. R. Silva
  2020-09-23  2:53   ` James Browning
  2020-09-27  6:27   ` Leon Romanovsky
  1 sibling, 2 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2020-09-23  2:39 UTC (permalink / raw)
  To: James Browning, kernelnewbies

Hi,

On 9/22/20 21:08, James Browning wrote:
> Hi all,
> 
> After reading through the kernel documentation about submitting pathces,
> and reading through the kernel newbies guide to submitting patches, I
> still have some confusion.
> 
> Should I be doing all of my patching against linux-next as opposed to
> the mainline tree? I tried submitting a patch to some typos I found on
> the mainline tree, but they were rejected because they had already been
> fixed in linux-next. 

Yes; bleeding edge development happens in linux-next. Just notice that
there is a new linux-next everyday. This is, linux-next is merely a daily
merge of all the individual development '-next' trees.

Don't get discouraged if your patches are not applied because someone
else already sent a patch to fix the same issue. That certainly happens
every now and then.

I suggest you to start your journey by addressing issues in staging, first.
Especially, typos and coding style issues. Also, this is a great resource:

https://kernelnewbies.org/Outreachyfirstpatch

Read it thoroughly. :)

> I guess I dont really understand what patches become part of the next
> mainline rc-x tree, and which patches become part of linux-next (which
> from what I understand, doesn't get merged until the next merge window when the current kernel version is finished being stabalized).

I encourage you to enroll in this course:

https://training.linuxfoundation.org/training/a-beginners-guide-to-linux-kernel-development-lfd103/

It's free and there is a section in the beginning that explains all
about the differences between mainline, -rc, linux-next and stable
trees and how they relate to each other.

> Also, if I patch something in the linux-next tree, do I need to specify
> which tree it is when I send the patch the maintainers?

Not necessarily. However, some people explicitly ask you to add 'next' to the
subject line. The networking people, in particular.

In any case, you'll be safe by adding [next] to the subject line, as follows:

[PATCH][next] subject

and the maintainers will know that's for their -next tree. Just make sure you
CC all the file maintainers.

I hope this helps.

--
Gustavo

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Confused about which branch to patch against
  2020-09-23  2:39 ` Gustavo A. R. Silva
@ 2020-09-23  2:53   ` James Browning
  2020-09-27  6:27   ` Leon Romanovsky
  1 sibling, 0 replies; 5+ messages in thread
From: James Browning @ 2020-09-23  2:53 UTC (permalink / raw)
  To: Gustavo A. R. Silva; +Cc: kernelnewbies

On Tue, Sep 22, 2020 at 09:39:41PM -0500, Gustavo A. R. Silva wrote: 
> I hope this helps.
> 
> --
> Gustavo

That does help, and thank you for the additional resources!

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Confused about which branch to patch against
  2020-09-23  2:39 ` Gustavo A. R. Silva
  2020-09-23  2:53   ` James Browning
@ 2020-09-27  6:27   ` Leon Romanovsky
  1 sibling, 0 replies; 5+ messages in thread
From: Leon Romanovsky @ 2020-09-27  6:27 UTC (permalink / raw)
  To: Gustavo A. R. Silva; +Cc: James Browning, kernelnewbies

On Tue, Sep 22, 2020 at 09:39:41PM -0500, Gustavo A. R. Silva wrote:
> Hi,
>
> On 9/22/20 21:08, James Browning wrote:
> > Hi all,
> >
> > After reading through the kernel documentation about submitting pathces,
> > and reading through the kernel newbies guide to submitting patches, I
> > still have some confusion.
> >
> > Should I be doing all of my patching against linux-next as opposed to
> > the mainline tree? I tried submitting a patch to some typos I found on
> > the mainline tree, but they were rejected because they had already been
> > fixed in linux-next.
>
> Yes; bleeding edge development happens in linux-next. Just notice that
> there is a new linux-next everyday. This is, linux-next is merely a daily
> merge of all the individual development '-next' trees.
>
> Don't get discouraged if your patches are not applied because someone
> else already sent a patch to fix the same issue. That certainly happens
> every now and then.
>
> I suggest you to start your journey by addressing issues in staging, first.
> Especially, typos and coding style issues. Also, this is a great resource:
>
> https://kernelnewbies.org/Outreachyfirstpatch
>
> Read it thoroughly. :)
>
> > I guess I dont really understand what patches become part of the next
> > mainline rc-x tree, and which patches become part of linux-next (which
> > from what I understand, doesn't get merged until the next merge window when the current kernel version is finished being stabalized).
>
> I encourage you to enroll in this course:
>
> https://training.linuxfoundation.org/training/a-beginners-guide-to-linux-kernel-development-lfd103/
>
> It's free and there is a section in the beginning that explains all
> about the differences between mainline, -rc, linux-next and stable
> trees and how they relate to each other.
>
> > Also, if I patch something in the linux-next tree, do I need to specify
> > which tree it is when I send the patch the maintainers?
>
> Not necessarily. However, some people explicitly ask you to add 'next' to the
> subject line. The networking people, in particular.
>
> In any case, you'll be safe by adding [next] to the subject line, as follows:
>
> [PATCH][next] subject

IMHO it looks clumsy, why don't [PATCH -next]?

>
> and the maintainers will know that's for their -next tree. Just make sure you
> CC all the file maintainers.
>
> I hope this helps.
>
> --
> Gustavo
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23  2:08 Confused about which branch to patch against James Browning
2020-09-23  2:28 ` James Browning
2020-09-23  2:39 ` Gustavo A. R. Silva
2020-09-23  2:53   ` James Browning
2020-09-27  6:27   ` Leon Romanovsky

Kernel Newbies Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kernelnewbies/0 kernelnewbies/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kernelnewbies kernelnewbies/ https://lore.kernel.org/kernelnewbies \
		kernelnewbies@kernelnewbies.org
	public-inbox-index kernelnewbies

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernelnewbies.kernelnewbies


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git