From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84561C4332B for ; Tue, 16 Mar 2021 17:23:22 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1270B6502E for ; Tue, 16 Mar 2021 17:23:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1270B6502E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94) (envelope-from ) id 1lMDPK-0004zz-0D; Tue, 16 Mar 2021 13:23:02 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lM9sM-0002CU-Kg for kernelnewbies@kernelnewbies.org; Tue, 16 Mar 2021 09:36:46 -0400 Received: by mail-wr1-x430.google.com with SMTP id o14so6673728wrm.11 for ; Tue, 16 Mar 2021 06:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7bLhDPuLSWfk3cqi2O7Xv2xxQBRYGHZeZiusa5rwe4c=; b=emDDfnDkZjL5XROGG8NZ0S6eXGoBK42uXSn4PwxAtCFdKRWSeXpnxiqXZbcHLgTDwn WbXrCMOmzzFxRA+gTc4tuG2qVsiEHRR4QtFMHWsDei2xQtxOQWCY5mXCuNigLEqoeyrR olqfMy2S2C/TklVqX3tP6ArISoKpsAJaZsou1S+kEq8vrcwHcdGPzOKRJU0E8djsqo0K 1AvSr+52ZCMU0us5YCmrKKt3ola+fyp6zgAxe7ovlAKHLTsNAn9VaOlLhl1PASPTd7iN VF75QxzZxqAX6S8wq+hdzEQgpEldVonE/P3k6BT2lLLI4etEoqwVbfan8OCctqR0R2Ct e/nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7bLhDPuLSWfk3cqi2O7Xv2xxQBRYGHZeZiusa5rwe4c=; b=UgwN+OS63zjJFFvm3fW8NXd/0l09hX75uEmKBIuFQ4Hqy7wyonM5KM7CVdyS2hT28P 6NjULU3EDxnbDbbYIEWBuqlajZpvXt349zzDhHuwNzNR6FFUbbP3N9LUDa0yncQqTwYy //h1bGS3gBBqq6O9eRr3UlHTDBghmqFbVGw+S1UNU+gfqfGBo9wMPOzdHesBROWGm8+F Fgy8waejDsQ2vJxO4I7r1x9LkJneF0HsWLBk1EXzbOHnxhWFP5huqN03hmYJnWrJ4DEc Hd5EM57bjGDmr0xDmvu4jg+73T/DOO9FhQm1aLyajTSNM/g4s5hwiwc83DKbMNlKNxh6 emNQ== X-Gm-Message-State: AOAM532bInWTMTJwKy50+UTbyyausfqg+iV4t4EhJZTOS75Mlfh119a3 FDWVAL6eZpeMpdi+egDM1Rk= X-Google-Smtp-Source: ABdhPJxwUCtxObCyAsCDfc6iKpAkZsob7P2k/VT17EV8+d65j/GD8O6eDW33c1ggIUQ1AgRb2QdUsA== X-Received: by 2002:adf:c186:: with SMTP id x6mr4981647wre.253.1615901803815; Tue, 16 Mar 2021 06:36:43 -0700 (PDT) Received: from agape.jhs ([5.171.72.71]) by smtp.gmail.com with ESMTPSA id 21sm3279133wme.6.2021.03.16.06.36.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 06:36:43 -0700 (PDT) Date: Tue, 16 Mar 2021 14:36:39 +0100 From: Fabio Aiuto To: Greg KH Subject: Re: [PATCH 05/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PM Message-ID: <20210316133638.GA1465@agape.jhs> References: <77ea39e63246fa4756afcf2bdea573f43fefc74c.1615801721.git.fabioaiuto83@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Tue, 16 Mar 2021 13:22:59 -0400 Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Tue, Mar 16, 2021 at 12:39:19PM +0100, Greg KH wrote: > On Mon, Mar 15, 2021 at 11:15:02AM +0100, Fabio Aiuto wrote: > > remove conditional code blocks checked by unused CONFIG_PM > > > > cleaning required in TODO file: > > > > find and remove code blocks guarded by never set CONFIG_FOO defines > > > > Signed-off-by: Fabio Aiuto > > --- > > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 -------- > > 1 file changed, 8 deletions(-) > > > > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > > index 2ff71d001c07..5748e1c1a25c 100644 > > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > > @@ -3198,14 +3198,6 @@ static void rtw_cfg80211_preinit_wiphy(struct adapter *padapter, struct wiphy *w > > wiphy->flags |= WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL; > > wiphy->flags |= WIPHY_FLAG_OFFCHAN_TX | WIPHY_FLAG_HAVE_AP_SME; > > > > -#if defined(CONFIG_PM) > > - wiphy->max_sched_scan_reqs = 1; > > -#endif > > - > > -#if defined(CONFIG_PM) > > - wiphy->wowlan = &wowlan_stub; > > -#endif > > How this is "unused"? This is a real config option, did you just change > the logic here? > > thanks, > > greg k-h Hi Greg, ignore this patch. I missed that definition of PM config option. I dropped it off my own local repo. Thank you, fabio _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies