From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D96C4338F for ; Thu, 29 Jul 2021 08:54:43 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBE1B61074 for ; Thu, 29 Jul 2021 08:54:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EBE1B61074 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94.2) (envelope-from ) id 1m91o5-0003bl-3b; Thu, 29 Jul 2021 04:54:21 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m91o2-0003b6-MS for kernelnewbies@kernelnewbies.org; Thu, 29 Jul 2021 04:54:18 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 411A81C0B79; Thu, 29 Jul 2021 10:54:14 +0200 (CEST) Date: Thu, 29 Jul 2021 10:54:13 +0200 From: Pavel Machek To: Ian Pilcher Subject: Re: [RFC PATCH 0/8] Add configurable block device LED triggers Message-ID: <20210729085413.GA16945@amd> References: <20210729015344.3366750-1-arequipeno@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210729015344.3366750-1-arequipeno@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: linux-block@vger.kernel.org, axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6100488638297177936==" Errors-To: kernelnewbies-bounces@kernelnewbies.org --===============6100488638297177936== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > This patch series adds configurable (i.e. user-defined) block device LED > triggers. >=20 > * Triggers can be created, listed, and deleted via sysfs block class > attributes (led_trigger_{new,list,del}). >=20 > * Once created, block device LED triggers are associated with LEDs just > like any other LED trigger (via /sys/class/leds/${LED}/trigger). >=20 > * Each block device gains a new device attribute (led_trigger) that can > be used to associate the device with a trigger or clear its > association. That's not how this is normally done. We normally have a trigger ("block device activity") which can then expose parameters ("I watch for read" and "I monitor sda1"). Is there a reason normal solution can not be used? Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --T4sUOijqQbZv57TR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmECbLUACgkQMOfwapXb+vL9tACgnOzb1KvTxmFtIJuKCic5ZIg/ y44AoKfmCU0r9lJBSrs3cIzBq6G/ZJhY =EPbJ -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR-- --===============6100488638297177936== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies --===============6100488638297177936==--