kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: "Alexander Ivanov" <amivanov@fastmail.com>
Cc: kernelnewbies@kernelnewbies.org
Subject: Re: GPIO Driver for Skylake-Y PCH
Date: Fri, 14 Jun 2019 15:09:26 -0400	[thread overview]
Message-ID: <25501.1560539366@turing-police> (raw)
In-Reply-To: <59c1b6d6-0545-4249-90cb-d1152b6ea728@www.fastmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1043 bytes --]

On Fri, 14 Jun 2019 12:01:28 -0700, you said:

> > static const struct pci_device_id pch_gpio_pcidev_id[] = {
> >  { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) },
> >  { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) },
> >  { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8043) },
> >  { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8803) },
> >  { 0, }
> > };
> > MODULE_DEVICE_TABLE(pci, pch_gpio_pcidev_id);

> It is a PCI device with 8086/9d20 IDs.

Give this patch a try, if it works I'll push it upstream for you...

diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index 1d99293096f2..19884b5b2a74 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -439,6 +439,7 @@ static SIMPLE_DEV_PM_OPS(pch_gpio_pm_ops, pch_gpio_suspend, pch_gpio_resume);

 static const struct pci_device_id pch_gpio_pcidev_id[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x9d20) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8043) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8803) },


[-- Attachment #1.2: Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

  reply	other threads:[~2019-06-14 19:09 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 17:58 GPIO Driver for Skylake-Y PCH Alexander Ivanov
2019-06-14 18:46 ` Valdis Klētnieks
2019-06-14 19:01   ` Alexander Ivanov
2019-06-14 19:09     ` Valdis Klētnieks [this message]
2019-06-14 20:25       ` Alexander Ivanov
2019-06-14 22:40         ` Alexander Ivanov
2019-06-15  8:53           ` Bjørn Mork
2019-06-15 19:30           ` Valdis Klētnieks
2019-06-15 19:38             ` Alexander Ivanov
2019-06-15 19:56               ` Greg KH
2019-06-16  1:50               ` Valdis Klētnieks
2019-06-16  2:45                 ` Alexander Ivanov
2019-06-16  8:54                   ` Bjørn Mork
2019-06-17  8:06             ` Andy Shevchenko
2019-06-18  0:00               ` Alexander Ivanov
2019-06-18  8:40                 ` Andy Shevchenko
2019-06-18 14:48                   ` Valdis Klētnieks
2019-06-18 15:57                     ` Andy Shevchenko
2019-06-18 16:17                       ` Alexander Ivanov
2019-06-20 21:02                   ` Alexander Ivanov
2019-06-21 10:12                     ` Andy Shevchenko
2019-06-21 17:39                       ` Alexander Ivanov
2019-06-24 18:39                         ` Alexander Ivanov
2019-06-25 11:08                           ` Andy Shevchenko
2019-06-25 14:10                             ` Linus Walleij
2019-07-10 16:04                               ` Andy Shevchenko
2019-08-28 21:04                             ` Alexander Ivanov
2019-08-29  7:47                               ` Valentin Vidić
2019-08-29 10:49                                 ` Andy Shevchenko
2019-08-29 11:49                                   ` Valentin Vidić
2019-08-29 14:59                                     ` Andy Shevchenko
2019-08-29 17:17                                       ` Valentin Vidić
2019-08-29 15:59                                 ` Alexander Ivanov
2019-06-14 19:12   ` Bjørn Mork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25501.1560539366@turing-police \
    --to=valdis.kletnieks@vt.edu \
    --cc=amivanov@fastmail.com \
    --cc=kernelnewbies@kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).