From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38911C43381 for ; Wed, 13 Mar 2019 06:41:59 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0602C2173C for ; Wed, 13 Mar 2019 06:41:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0602C2173C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vt.edu Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.91) (envelope-from ) id 1h3xa0-00082i-4e; Wed, 13 Mar 2019 02:41:32 -0400 Received: from omr2.cc.ipv6.vt.edu ([2607:b400:92:8400:0:33:fb76:806e] helo=omr2.cc.vt.edu) by shelob.surriel.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h3xZy-00082G-B4 for kernelnewbies@kernelnewbies.org; Wed, 13 Mar 2019 02:41:30 -0400 Received: from mr2.cc.vt.edu (inbound.smtp.ipv6.vt.edu [IPv6:2607:b400:92:9:0:9d:8fcb:4116]) by omr2.cc.vt.edu (8.14.4/8.14.4) with ESMTP id x2D6fSJY027260 for ; Wed, 13 Mar 2019 02:41:28 -0400 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mr2.cc.vt.edu (8.14.7/8.14.7) with ESMTP id x2D6fMUw017089 for ; Wed, 13 Mar 2019 02:41:27 -0400 Received: by mail-qk1-f200.google.com with SMTP id t13so705047qkm.2 for ; Tue, 12 Mar 2019 23:41:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:date:message-id; bh=LqbshWlTPgp8qIAodxKeAsbAxIVIFbC9vlF+iM4Wris=; b=qGmnz8v0zP9U/Nz4uRtlTwohxlLMp8wRHtTnMmi+EKMTe3C1PgjSyxhj7ZE+OotsQb mzfEh91xJhvPi+82Ulk6jx0lbGkKPvZwgS424AU+vIFQtvUFQim0a68Y9Y4pGGhl5NTO NFwR9bBHAy2ejbHeWT/jArDXPhoHQ7qpr6kulES6a8maq4SyMXQkPytQDMZVA279/PTp 47pOrtVCc3RFcEMdHNpYRwOu7H5yvRacXMpm7/R/3RRGX3472phsTH4hlPGgPyo5Pw4Q 5S56tCi07kw9iuimWOBOYOb5wh2o8XqZ2IZifhwFLShfTHZDp+Q3QQqLHaqe+trc2OHW 2hjg== X-Gm-Message-State: APjAAAViaYKpkYG0T1kfCVSjvfNKimCQUJsNrXL28DQGq0BvQrZebatB E1LzZEVObbhH+OyoKyzBSx3i6f5tPcjQbqZdVJzIckGBmbviB8s8hTHS2rttiLvKlcUMGKNkWeJ 8QeEaA7F+WPXgk/iP0r0Roj+hmy/+5WsWKAi0SlA= X-Received: by 2002:ac8:2314:: with SMTP id a20mr33610387qta.127.1552459282791; Tue, 12 Mar 2019 23:41:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqycUnUoD+i3BGJzPjKtPVbCndyjew23/Xrz8xd9BFUlDJEF1h6dpotHKnDUaZssCYO2BHdwlw== X-Received: by 2002:ac8:2314:: with SMTP id a20mr33610376qta.127.1552459282602; Tue, 12 Mar 2019 23:41:22 -0700 (PDT) Received: from turing-police ([2601:5c0:c001:4341::3b7]) by smtp.gmail.com with ESMTPSA id h186sm6364243qkd.15.2019.03.12.23.41.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2019 23:41:21 -0700 (PDT) From: valdis.kletnieks@vt.edu X-Google-Original-From: Valdis.Kletnieks@vt.edu X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: Gao Xiang Subject: Re: [PATCH 1/1] staging: erofs: Add function comment for erofs/super.c In-reply-to: <2d0544aa-cc99-f1dd-3b83-9f06a307dfc7@aol.com> References: <2d0544aa-cc99-f1dd-3b83-9f06a307dfc7@aol.com> Mime-Version: 1.0 Date: Wed, 13 Mar 2019 02:41:20 -0400 Message-ID: <26452.1552459280@turing-police> Cc: Gao Xiang , arshad hussain , kernelnewbies , linux-erofs@lists.ozlabs.org, Greg Kroah-Hartman , miaoxie@huawei.com X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Wed, 13 Mar 2019 08:48:26 +0800, Gao Xiang said: (Reversing order of comments) > "Release slab Memory" is not a very useful description for this function. Agreed. > i_callback is used to free inode structure and other memory related to this inode However, that's not a bad description at all. :) (Though I'd consider renaming the function to 'reap_inode_mem()' or something like that so no description is needed. :) _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies