From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Martin Galvan <omgalvan.86@gmail.com>
Cc: kernelnewbies@kernelnewbies.org
Subject: Re: Try/catch for modules?
Date: Thu, 17 Oct 2019 18:12:57 -0400 [thread overview]
Message-ID: <29246.1571350377@turing-police> (raw)
In-Reply-To: <CAN19L9FAXYVohxQ9Td=gV2MuVzArAgnO2YmcoFen7Y2PEmbV8A@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 694 bytes --]
On Thu, 17 Oct 2019 10:37:09 -0300, Martin Galvan said:
> module does e.g. a NULL dereference. The (horribly hackish) way I'm
> doing this right now is registering a die_notifier which will set the
> 'panic_on_oops' variable to 0 if we detect that the current PID
> corresponds to my module. However, this is ugly for many reasons.
For starters, the *correct* in-kernel way to deal with this is:
if (!ptr) {
printk("You blew it!\n");
goto you_blew_it;
}
Also, "current PID" and "my module" aren't two things that can correspond....
For double bonus points - this sort of "ignore the error if it's my process" means
that any other user can trigger the situation - and crash the system.
[-- Attachment #1.2: Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2019-10-17 22:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 13:37 Try/catch for modules? Martin Galvan
[not found] ` <CAG=DERmX7AU8YkEAYnPLfPKCLD=1OugmD95R9wZ3CepXvqzd2Q@mail.gmail.com>
2019-10-17 13:42 ` Maria Neptune
2019-10-17 13:51 ` Ruben Safir
2019-10-17 22:12 ` Valdis Klētnieks [this message]
2019-10-18 15:43 ` Martin Galvan
2019-10-18 15:47 ` Anuz Pratap Singh Tomar
2019-10-18 15:48 ` Maria Neptune
2019-10-18 16:04 ` Bernd Petrovitsch
2019-10-18 16:11 ` Martin Galvan
2019-10-18 16:18 ` Bernd Petrovitsch
2019-10-18 17:02 ` Ruben Safir
2019-10-18 17:05 ` Martin Galvan
2019-10-18 18:52 ` Ruben Safir
2019-10-18 18:53 ` Ruben Safir
2019-10-18 19:08 ` Ruben Safir
2019-10-18 21:53 ` Valdis Klētnieks
2019-10-18 22:09 ` Martin Galvan
2019-10-18 22:28 ` Greg KH
2019-10-18 18:48 ` Ruben Safir
2019-10-18 21:24 ` Rik van Riel
2019-10-18 21:32 ` Ruben Safir
2019-10-18 21:37 ` Ruben Safir
2019-10-18 22:59 ` Valdis Klētnieks
2019-10-19 7:46 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29246.1571350377@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=kernelnewbies@kernelnewbies.org \
--cc=omgalvan.86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).