* functions with empty body in file /kernel/events/core
@ 2020-08-08 17:48 cristian andres vargas gonzalez
2020-08-08 19:56 ` Valdis Klētnieks
0 siblings, 1 reply; 2+ messages in thread
From: cristian andres vargas gonzalez @ 2020-08-08 17:48 UTC (permalink / raw)
To: kernelnewbies
[-- Attachment #1: Type: text/html, Size: 2110 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: functions with empty body in file /kernel/events/core
2020-08-08 17:48 functions with empty body in file /kernel/events/core cristian andres vargas gonzalez
@ 2020-08-08 19:56 ` Valdis Klētnieks
0 siblings, 0 replies; 2+ messages in thread
From: Valdis Klētnieks @ 2020-08-08 19:56 UTC (permalink / raw)
To: cristian andres vargas gonzalez; +Cc: kernelnewbies
[-- Attachment #1.1: Type: text/plain, Size: 977 bytes --]
On Sat, 08 Aug 2020 12:48:08 -0500, cristian andres vargas gonzalez said:
> Who have an empty body,
Which is a reasonable thing to have, if the function doesn't do anything on a given
architecture or configuration.
> I understand that they are inside a conditional created by the preprocessor
> directives and also that they are called in some parts of the code , but would
> it really be necessary that when the directive is not true to leave the
> function with the body empty, would it be a solution?
I admit being confoozled here - would leaving a function with an empty body be
a solution? Obviously it *would* be one, because the kernel currently does
that.
> Or is it just missing to eliminate those functions without a body?
Feel free to try it and see what happens. :) (Make sure to try two different
configs, one that includes the version that has the non-empty body, and
one that tries to call the eliminated function without a body).
[-- Attachment #1.2: Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-08 19:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-08 17:48 functions with empty body in file /kernel/events/core cristian andres vargas gonzalez
2020-08-08 19:56 ` Valdis Klētnieks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).