From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Greg KH <greg@kroah.com>
Cc: Martin Christian <martin.christian@secunet.com>,
kernelnewbies@kernelnewbies.org
Subject: Re: Unexpected scheduling with mutexes
Date: Fri, 29 Mar 2019 17:45:56 -0400 [thread overview]
Message-ID: <5772.1553895956@turing-police> (raw)
In-Reply-To: <20190329200158.GF12004@kroah.com>
On Fri, 29 Mar 2019 21:01:58 +0100, Greg KH said:
> But if you are trying to somehow create a real api that you have to
> enforce the passing off of writing data from two different character
> devices in an interleaved format, you are doing this totally wrong, as
> this is not going to work with a simple mutex, as you have found out.
There's almost always an even more fundamental issue here - I've seen plenty of
people attempt to do this sort of thing. But invariably, they have little to
no explanation of what semantics they think are correct. I'm not sure who are
crazier - the people who try to do kernel-side locking for "exclusive" use of a
device, or the people who don't understand why having 3 different programs
trying to talk to /dev/ttyS0 at once will only lead to tearns and anguish...
(Though recently, I discovered that there are no bad ideas so obvious that
somebody won't try to re-invent them. I caught a software package that *really*
should know better using "does DBus have an entry for this object?" as a lock.)
> Try to take USB out of the picture as well as userspace, and try running
> two kernel threads trying to grab a mutex and then print out "A" or "B"
> to the kernel log and then give it up. Is that output nicely
> interleaved or is there some duplicated messages.[1]
> [1] Extra bonus points for those that recognize this task...
Been there, done that, got the tire marks to prove it. :)
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2019-03-29 21:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 10:56 Unexpected scheduling with mutexes Martin Christian
2019-03-29 20:01 ` Greg KH
2019-03-29 21:45 ` Valdis Klētnieks [this message]
2019-03-30 12:25 ` Ruben Safir
2019-03-30 18:35 ` Greg KH
2019-04-03 9:33 ` Martin Christian
2019-04-03 9:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5772.1553895956@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=greg@kroah.com \
--cc=kernelnewbies@kernelnewbies.org \
--cc=martin.christian@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).