From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9770CA9EAE for ; Wed, 23 Oct 2019 05:38:54 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6710F2173B for ; Wed, 23 Oct 2019 05:38:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6710F2173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vt.edu Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.92.3) (envelope-from ) id 1iN9Lq-0001Dp-VW; Wed, 23 Oct 2019 01:38:30 -0400 Received: from omr2.cc.ipv6.vt.edu ([2607:b400:92:8400:0:33:fb76:806e] helo=omr2.cc.vt.edu) by shelob.surriel.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1iN9Lo-0001Dh-DP for kernelnewbies@kernelnewbies.org; Wed, 23 Oct 2019 01:38:28 -0400 Received: from mr3.cc.vt.edu (mr3.cc.vt.edu [IPv6:2607:b400:92:8500:0:7f:b804:6b0a]) by omr2.cc.vt.edu (8.14.4/8.14.4) with ESMTP id x9N5cQLE021015 for ; Wed, 23 Oct 2019 01:38:26 -0400 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mr3.cc.vt.edu (8.14.7/8.14.7) with ESMTP id x9N5cLKe028061 for ; Wed, 23 Oct 2019 01:38:26 -0400 Received: by mail-qk1-f198.google.com with SMTP id x77so19084616qka.11 for ; Tue, 22 Oct 2019 22:38:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:content-transfer-encoding:date:message-id; bh=kP4uvllOyp5GRffGVmkHTNcM4gNFMsODV/1P3hfkGTs=; b=s+R+fsRw8D1zYjv3/PZQDGuf3+ZrgNqXE9pjgn5QUjCRgDU9ysLM3rHFDTbZ8K/Z1O rMi4nqBCtFOMAeQc6c0DW4ax2b+Y3xnbh5K6MTK/eWMjcobMmb8bXq+QLXy4nyXZg6AJ C+3TAREejDRR1gqekACkTXoMKUbB1RwaAqE0F/DlO7dpWiLgBCPBDX4mPvjSGJU1Pmlx WRVgqJRhwrq5ijgCIS1/PxUQvbA/Op6auzx4GHJSIGiC/sbi1d45ZMcl0x6vO2NgYI+Y L+GUYtrdU4s2MxewOvC0WEKpo9U1oN2Z9OVP1YZgHWqWy340+8qyKs4eJWjNovRdjoVM CYYQ== X-Gm-Message-State: APjAAAVEcsSWLl2FFFz8EHdbRXNuCp8WeD4AboidhYbsvNanlovCy0Ri 7nvJTn06wknFvYx5JGNHLY0O0Et3hkPKtohytMnvLCXotPdPU3IkqSKqedup95FHml7UZi26qpl +j5YcE8xo6bsznfRP4CkSWAuXs14iRXwj1RRashQ= X-Received: by 2002:a37:2fc1:: with SMTP id v184mr6878245qkh.18.1571809100647; Tue, 22 Oct 2019 22:38:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqw7x5snUeFTx+2CziXqSPmBs85uaBepzDEb0jKcTD3Uv1B6RRAaDUbQC5hlL4uWvQRJRLZ3Tw== X-Received: by 2002:a37:2fc1:: with SMTP id v184mr6878226qkh.18.1571809100281; Tue, 22 Oct 2019 22:38:20 -0700 (PDT) Received: from turing-police ([2601:5c0:c001:c9e1::359]) by smtp.gmail.com with UTF8SMTPSA id m15sm9140258qka.104.2019.10.22.22.38.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 22:38:13 -0700 (PDT) From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: Irfan Ullah (울라 이르판) Subject: Re: Netlink socket returns NULL in vmx.c kernel file In-Reply-To: References: Mime-Version: 1.0 Date: Wed, 23 Oct 2019 01:38:12 -0400 Message-ID: <694299.1571809092@turing-police> Cc: kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6070798794730953214==" Errors-To: kernelnewbies-bounces@kernelnewbies.org --===============6070798794730953214== Content-Type: multipart/signed; boundary="==_Exmh_1571809092_59326P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit --==_Exmh_1571809092_59326P Content-Type: text/plain; charset=us-ascii On Wed, 23 Oct 2019 11:43:22 +0900, Irfan Ullah said: > Can you please what's the problem? To be brutally honest, your code is too unreadable to figure out what the problem is. First off, fix your code formatting to match Linux kernel indenting. Second, there's a lot of code in your .h file that should be in a .c file. Third, functions should be static when feasible. --==_Exmh_1571809092_59326P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Comment: Exmh version 2.9.0 11/07/2018 iQIVAwUBXa/nQwdmEQWDXROgAQKGlBAAoRu8+c8rHjdEfbweKbmHFZdYDqTE4zXn xTBQA3PeoiZ2hzGIXpSHbcIVptQMNm5FHiGlv8jAoD2YbXU0OCrImn+fF9FvufP2 hRaVxRi3IqibhGVoVXwCJREFcVup9mYa8yy6boQP5lQa2ogFInZYwPc7e0Ur8+N1 ZhalebWVvymGgFLanUVtRQNT3WAQUCBd9e5Tmh84Uo9bs/1QHGJGWXC+S1TS6e4h 812Rzxx0slssMmG0al9WVn0m+/ei4bFP4qEddQ4IlcxkUfjyhTPIelG5T6dH55rN idahQ+5EpiKX6FU0ZDOwu0AWVwAw9gIueIWzPj5wGjuRTplQVWK0TQI/vvghYmVB PdFRGKQobmeVeFHEy5/ljY0YQip3HWZpqzWddda9mGOG/AISxytI5DkQ35dPP04B Vn8qoX0Dnc5INxFsxxvXLeIqK1AhC7T6DuABbOLLeQUWSOl84wmbNHIiQ+EyvsFT QkkONaHwujEkc44yAsaywcw03Ar1YZkIS0D7okecXMXPKHc/sqYtI/xagfBhR3Gd VSQsx7+jdhyQ6WSDClOnSIUBgi+JW6UViKkYaabMXgDzfVfahjv4coMT35cKaQ1W XGqWtT0oK7uMHJJBJVq48alYdpFqMyrhb7YO6PImz+/AJf+dIQET8HFPTwjhyUo8 Xz/PmQ/gmSs= =Vufv -----END PGP SIGNATURE----- --==_Exmh_1571809092_59326P-- --===============6070798794730953214== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies --===============6070798794730953214==--