From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7312C433EF for ; Fri, 17 Sep 2021 22:04:00 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 566D1610A4 for ; Fri, 17 Sep 2021 22:04:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 566D1610A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vt.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mRLst-0005I9-QQ; Fri, 17 Sep 2021 17:59:03 -0400 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mRLsn-0005Hl-DJ for kernelnewbies@kernelnewbies.org; Fri, 17 Sep 2021 17:58:58 -0400 Received: by mail-qk1-x72f.google.com with SMTP id a10so21957392qka.12 for ; Fri, 17 Sep 2021 14:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vt-edu.20210112.gappssmtp.com; s=20210112; h=sender:from:to:cc:subject:in-reply-to:references:mime-version :content-transfer-encoding:date:message-id; bh=9gCKWzaiFmWVCLju+/yLfG+w1R8Ij0IHvfZztahLT9c=; b=bctpMfPpzWM18jNSy9EBwsQu2rVD+W0r8POBaId5nnwW89kSw5RVZ0ymdRhuUBsj0q KcV8ohQJGWva+8vD9U70szc5QngVjQav+6FAe6HgQBvADre+PJ96w+Oss/YvhCFPVw7c ZzscgUWQVyObAamLQRg2xKSuUSvCF5daNO40UbMsSyCSksjy/xtLvmYBIEJ6B8hIvGE/ H2RsV+5xgKVoD9nBxZnd7y4CNgHcs2nsy3S5jG/HnDa12diBrDI9bHcG1hqZf1gSlu49 qmdF7M+7aj9XVkopSHaFTKP73XKuYGDHhSSMw9QJd+y9aSgZ1N+G69lbn12RlCxuZDyC rIzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:content-transfer-encoding:date:message-id; bh=9gCKWzaiFmWVCLju+/yLfG+w1R8Ij0IHvfZztahLT9c=; b=EGiN9+JRkU4i2THaVP3WBqoUJaGeBQYDnka1nUs0kNQbE3SLF0pQjwFsSw2YsGlB4h 5lAF854HfpfkHQbNNSppVAnForPAzyIIKdC93sw2c7QaMk6TfMyjHHelRo5pxTtrelr0 BDHSxe8LyxPjstg+ynatwNPaWFDh90eTE/XXQn3cuFwOAl1H7SkBKe0iEdvZdb2+Nx5R /yBAtUA/Eg14gY7I+NjG3qHN0vYo5kp1JZlmZAuBv5X+9y7qQhsH9R+lHH3jRHys1VE1 39gMnLfBQOewg4VHUMxDV8w+SA9mVFstgFqpt1Y1eolaXLlb1lXFwgCcbUkZaBHonSSf eZOg== X-Gm-Message-State: AOAM533GKt+ebkOjJOm/lL0Yl4/Msk0hhZ+s0BhpytZhO4M3UJTMluS2 l3SL6Wy0TSuk8jgzwXSnjOPWAxHBmXjnYg== X-Google-Smtp-Source: ABdhPJzo9YsvIWmGOmaErOT/ZW+YZb5Fj+HNWcYaxv8tvcLKd1wsSjDES43L3W/B8G8003z4l5bq+w== X-Received: by 2002:ae9:ea19:: with SMTP id f25mr12859141qkg.341.1631915929590; Fri, 17 Sep 2021 14:58:49 -0700 (PDT) Received: from turing-police ([2601:5c0:c380:d61::359]) by smtp.gmail.com with ESMTPSA id u4sm525486qtq.31.2021.09.17.14.58.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Sep 2021 14:58:48 -0700 (PDT) From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.10.0-pre 07/05/2021 with nmh-1.7+dev To: FMDF Subject: Re: Commit messages in a series of patches In-Reply-To: References: Mime-Version: 1.0 Date: Fri, 17 Sep 2021 17:58:48 -0400 Message-ID: <90319.1631915928@turing-police> Cc: kernelnewbies X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2114739479599675204==" Errors-To: kernelnewbies-bounces@kernelnewbies.org --===============2114739479599675204== Content-Type: multipart/signed; boundary="==_Exmh_1631915927_88012P"; micalg=pgp-sha256; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit --==_Exmh_1631915927_88012P Content-Type: text/plain; charset=us-ascii On Fri, 17 Sep 2021 11:12:45 +0200, FMDF said: > My question is: why "This patch is preparation for _io_ops [future] > structure removal." is good while "Eventually this function will be > deleted but some of the code will be reused later." is not. The first is specific about what is being changed and why, and tells the reviewer what to watch for. Also, the reviewer now knows where to look for justification - there is hopefully a 0/N patch that explains why and how this structure is being removed. The second doesn't say which "this function" is being removed, why this is being done, or whether the changes were internal to the function, or in other functions. It also doesn't explain why or how code will be re-used. The distinction matters, because the biggest point of reviewing is "Does this commit do what was intended?" Answering that question is a lot easier when it's clear what was intended. --==_Exmh_1631915927_88012P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Comment: Exmh version 2.9.0 11/07/2018 iQEcBAEBCAAGBQJhRQ+XAAoJEI0DS38y7CIcY7gH/1i7GXom4iDMWU/EjPN5v/59 7KYOLFetRhmoumE4Lq18VuXmcID+PAnwCODbIZvOByvHd1yjv9gy5pmsDGKwOTxr Ntq/32vO0jxfZMyyXCifDgaFTi2SBW0c9/dXGr42hX/mOGeITID74JxJKfZZwI+h mqljbf9zcZ8BHTFaSZ2HyJMRse49fjactRsPIWNW9/Cv7ND1mOoOuCMyNtSTGNon +AdYILnp47eu6MnMLPefqxf9L3dP1+pBnfUuoCBJh1NCC/otBOsg4HjuDsoj2yUV 3vbp0dW3CUpMb6hPzeAZeDTWfZGnlYhLFwrtNkx8nSLa+6dvjOJt/B79TMcNhmM= =E/yk -----END PGP SIGNATURE----- --==_Exmh_1631915927_88012P-- --===============2114739479599675204== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies --===============2114739479599675204==--