From: Ian Pilcher <arequipeno@gmail.com>
To: Jackie Liu <liuyun01@kylinos.cn>,
linux-block@vger.kernel.org, linux-leds@vger.kernel.org
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, pavel@ucw.cz,
kernelnewbies@kernelnewbies.org
Subject: Re: [RFC PATCH v2 05/10] block: Add block device sysfs attribute to set/clear/show LED
Date: Mon, 9 Aug 2021 10:44:07 -0500 [thread overview]
Message-ID: <94f034a0-4c65-48d3-3eaa-a57ceb6a8ce3@gmail.com> (raw)
In-Reply-To: <d2322db3-992a-f9c1-53c4-39efc9d957a4@kylinos.cn>
On 8/8/21 11:21 PM, Jackie Liu wrote:
>> +// Returns a pointer to the first whitespace character in s (or a pointer to
>> +// the terminating null), which is effectively a pointer to the position *after*
>> +// the last character in the non-whitespace token at the beginning of s. (s is
>> +// expected to be the result of a previous call to blk_ledtrig_skip_whitespace.)
>
> These are not linux kernel style comments.
Do you mean kernel-doc comments? If so, they're not supposed to be, as
the functions are not exported.
>> +static const char *blk_ledtrig_find_whitespace(const char *s) ^^^^^^
--
========================================================================
In Soviet Russia, Google searches you!
========================================================================
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2021-08-09 15:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 3:32 [RFC PATCH v2 00/10] Add configurable block device LED triggers Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 01/10] docs: Add block device LED trigger documentation Ian Pilcher
2021-08-10 13:49 ` Pavel Machek
2021-08-09 3:32 ` [RFC PATCH v2 02/10] block: Add file (blk-ledtrig.c) for block device LED trigger implementation Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 03/10] block: Add block device LED trigger fields to gendisk structure Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 04/10] block: Add functions to set & clear block device LEDs Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 05/10] block: Add block device sysfs attribute to set/clear/show LED Ian Pilcher
2021-08-09 4:21 ` Jackie Liu
2021-08-09 15:44 ` Ian Pilcher [this message]
2021-08-09 3:32 ` [RFC PATCH v2 06/10] block: Add activate and deactivate functions for block device LED trigger Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 07/10] block: Add sysfs attributes to LEDs associated with blkdev trigger Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 08/10] block: Add init function for block device LED trigger Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 09/10] block: Blink device LED (if any) when request is sent to its driver Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 10/10] block: Add config option to enable block device LED triggers Ian Pilcher
2021-08-09 18:56 ` [RFC PATCH v2 00/10] Add configurable " Marek Behún
2021-08-09 19:07 ` Pali Rohár
2021-08-09 19:54 ` Ian Pilcher
2021-08-09 22:43 ` Marek Behún
2021-08-09 23:50 ` Ian Pilcher
2021-08-10 6:35 ` Greg KH
2021-08-10 13:38 ` Marek Behún
2021-08-10 14:48 ` Greg KH
2021-08-10 15:55 ` Ian Pilcher
2021-08-10 16:24 ` Greg KH
2021-08-10 16:39 ` Marek Behún
2021-08-10 16:43 ` Ian Pilcher
2021-08-11 6:26 ` Christoph Hellwig
2021-08-11 10:50 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94f034a0-4c65-48d3-3eaa-a57ceb6a8ce3@gmail.com \
--to=arequipeno@gmail.com \
--cc=axboe@kernel.dk \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).