From: "XenoN. w0w" <e-net15@hotmail.com>
To: Jefferson Carpenter <jefferson@aoeu2code.com>,
"kernelnewbies@kernelnewbies.org"
<kernelnewbies@kernelnewbies.org>
Subject: Re: checkpatch.pl CHECK alignment
Date: Mon, 2 Sep 2019 16:47:26 +0000 [thread overview]
Message-ID: <C559E8AD-26E0-4207-ADB3-BB22AB2DCBED@hotmail.com> (raw)
In-Reply-To: <57efce85-4116-d2a5-67b2-069869a80a06@aoeu2code.com>
Alright, thanks for answering
On 02/09/2019, 18:42, "Jefferson Carpenter" <jefferson@aoeu2code.com> wrote:
IMHO formatting reasons are not enough to submit a patch, unless the
formatting is really whack. If it's off by one space, it probably
doesn't matter. Enough lines get changed anyway without the "noise" of
re-formatting something. If you are touching that code anyway or
something very near it, then you might go ahead and change the
formatting also.
On 9/2/2019 4:17 PM, XenoN. w0w wrote:
> Hello all, I am running checkpath.pl against one driver and I’m getting
> CHECK: Alignment should match open parenthesis
>
> Are these lines worth of changing, what are the odds of that patch being accepted. I’m new and I want to contribute so sorry for dumb question
>
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2019-09-02 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 16:17 checkpatch.pl CHECK alignment XenoN. w0w
2019-09-02 16:42 ` Jefferson Carpenter
2019-09-02 16:47 ` XenoN. w0w [this message]
2019-09-02 18:33 ` Valdis Klētnieks
2019-09-02 18:38 ` XenoN. w0w
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C559E8AD-26E0-4207-ADB3-BB22AB2DCBED@hotmail.com \
--to=e-net15@hotmail.com \
--cc=jefferson@aoeu2code.com \
--cc=kernelnewbies@kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).