From: Tomek The Messenger <tomekthemessenger@gmail.com>
To: kernelnewbies@kernelnewbies.org
Subject: linux kernel coding style and checkpatch.pl script
Date: Wed, 25 Mar 2020 10:36:08 +0100 [thread overview]
Message-ID: <CAA4NGys4OphSLnyoRE9MN-_yQ5kFykr-NGdRW+RxR02TyYOr+g@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 908 bytes --]
Hi
There is checkpatch.pl script where You can check if You wrote code in your
kernel module according to linux kernel style.
However can I ignore warning message?
WARNING: quoted string split across lines
#974: FILE: fpgax67-core.c:974:
+ dev_err(&pdev->dev, "registration not done, driver is
already "
+ "registered\n");
If I don't split line I will have another warning that 80 characters is
exceeded.
For sure I can ignore warnings about:
WARNING: struct should normally be const
#998: FILE: fpgax67-core.c :998:
+int fpgax67_unregister(struct platform_device *pdev)
For sure all errors must be fixed like:
const char* tmp -> change to -> const char *tmp;
if( => if ( #insert space
Generally I don't know how much warnings should I correct. If it is
mandatory or only good practise and I can omit some if it doesn't make
sense.
[-- Attachment #1.2: Type: text/html, Size: 1244 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next reply other threads:[~2020-03-25 9:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 9:36 Tomek The Messenger [this message]
2020-03-25 9:51 ` linux kernel coding style and checkpatch.pl script Greg KH
2020-03-26 4:13 ` Valdis Klētnieks
2020-03-26 11:36 ` Konstantin Andreev
[not found] ` <E1jHQrV-0002Zv-Ln@shelob.surriel.com>
2020-03-26 12:06 ` Greg KH
2020-03-26 13:01 ` Konstantin Andreev
[not found] ` <E1jHS2D-0004t2-IX@shelob.surriel.com>
2020-03-26 13:17 ` Greg KH
2020-03-26 10:57 ` Anuz Pratap Singh Tomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA4NGys4OphSLnyoRE9MN-_yQ5kFykr-NGdRW+RxR02TyYOr+g@mail.gmail.com \
--to=tomekthemessenger@gmail.com \
--cc=kernelnewbies@kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).