From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9579CC3A5A5 for ; Tue, 3 Sep 2019 04:26:44 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 463F721897 for ; Tue, 3 Sep 2019 04:26:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J6N0YRsQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 463F721897 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.92) (envelope-from ) id 1i50On-00061X-Bb; Tue, 03 Sep 2019 00:26:33 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by shelob.surriel.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1i50Ol-00061R-Bu for kernelnewbies@kernelnewbies.org; Tue, 03 Sep 2019 00:26:31 -0400 Received: by mail-wm1-x330.google.com with SMTP id r17so13307462wme.0 for ; Mon, 02 Sep 2019 21:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=LFOpoYJw7X6vUR1aBkfKXMmQzEGxNchIV9/X4i31ap8=; b=J6N0YRsQmhWtqaqsTLIwvvO9XUbYihSmZ/QXSnquba3SFkxejXopUQe3c6L5Dzt+Tk ZLj6Byp/MXGLje5wnQ/38wkEa77Fg4NiJjrQwNNcbYlkwKi2xjLWXexOqojaJcvlqauV S2oestaQnFvP66sbBAS89ZBXVyrpFFj43E8jiTfsOdv2DF6XXmvd9eXMK1PDVHEsaBuo iBqEyeP9tAkB4fThCw2FmsuEHvY1arkISV7kUi9XpklHNZECQXfGicr6F5KfBL9E+856 d3a8hWSR/T+v9ArgdEtjkhTh7MmMOFLc/efdRrBk0/Mo1mgWOQW081pFS7Gi5dlmy7q+ s7uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=LFOpoYJw7X6vUR1aBkfKXMmQzEGxNchIV9/X4i31ap8=; b=JHJJ2MT4+ydjN3yNsJgtn0OZJRof48ixBHAobCysEyle/H+JDP5mEGSV8Kokwl9EZJ iaTwD3XAGNGN1SEjlbD6enRNz8yfjMma7DPwG1Ur2N8iLJrn1Z+Fqh8U/l+JbTGX5S21 RGEaLq73h00jDSEI6fqZZUbBrNC1KSgJMw2IhPmFi8NpOHPDm+TeOCri30AZf7WWhH3D CraY2ZpFdi8lPVVzauE5vZR5bjanVJekt22jRZ3O/TKh1p5Yw89RI8/VwxHztbMER0p+ Mtj9z0H0CdLLqejA+blcDoaHub7FwUqfWa+02gOHAhhvEbHEVT8njaNUm2DKpsib/PGg /L2Q== X-Gm-Message-State: APjAAAXob8t+lGIrMdiI7ip9DJf4sEkUQW7JZ7+akAjolDFY+E5KliXK w8XdjbWjsSkXvGaASoaZtA2goFkaCO7EYhZXU9pnDGeFUr7FXg== X-Google-Smtp-Source: APXvYqyUj7OSwGEuz3xjIRdBkiWNlgFe7rXn3U5HgMF7soVrXCEFRd69wRyI41qaNyUq1v/ynDpYsYWQ2IvDVAx+Vjs= X-Received: by 2002:a1c:1ac2:: with SMTP id a185mr4423579wma.96.1567484788831; Mon, 02 Sep 2019 21:26:28 -0700 (PDT) MIME-Version: 1.0 From: Pablo Pellecchia Date: Tue, 3 Sep 2019 01:26:17 -0300 Message-ID: Subject: Staging/netlogic coding style issues with struct To: kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0009054076267029743==" Errors-To: kernelnewbies-bounces@kernelnewbies.org --===============0009054076267029743== Content-Type: multipart/alternative; boundary="000000000000077a5d05919e7e41" --000000000000077a5d05919e7e41 Content-Type: text/plain; charset="UTF-8" Greetings, I'm fixing some issues on the staging/netlogic directory and I see that checkpatch.pl is throwing the following warnings on some files: *WARNING: struct should normally be const#9: FILE: platform_net.h:9:+struct xlr_net_data {* A similar issue is reported when we declare a variable of type struct , but in this case warning is reported on the struct definition itself. How can we fix this? Thanks! --000000000000077a5d05919e7e41 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Greetings,

I'm fixing so= me issues on the staging/netlogic directory and I see that checkpatch.pl is throwing the following warnings on so= me files:

WARNING: struct =C2=A0should n= ormally be const
#9: FILE: platform_net.h:9:
+struct xlr_net_data {

A similar issue is reported when we declare a v= ariable of type struct <something>, but in this case warning is repor= ted on the struct definition itself.

How can we fi= x this?

Thanks!
--000000000000077a5d05919e7e41-- --===============0009054076267029743== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies --===============0009054076267029743==--