From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC85EC433E0 for ; Wed, 24 Mar 2021 13:22:01 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 502F861A0A for ; Wed, 24 Mar 2021 13:22:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 502F861A0A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94) (envelope-from ) id 1lP3SE-00063C-M3; Wed, 24 Mar 2021 09:21:46 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lP3SC-000636-D9 for kernelnewbies@kernelnewbies.org; Wed, 24 Mar 2021 09:21:44 -0400 Received: by mail-ej1-x633.google.com with SMTP id e14so14615340ejz.11 for ; Wed, 24 Mar 2021 06:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pSN9UAFB86h/tQZuVxtE7O47u5mZBXvhHQv7b1+5Vg4=; b=qsNVRzjY5EduAW843lGC4IrT0ng6J2OlR5zH7RERBYNPfn0EyyX7Z/CWgDhomUveGO mzA51PpU5MP3WC/Ucoxxtx6GGUR4Ok90Z9Ss7xRl5ryPHtg0tY+ZXmzlvzo4vOMKo09F facMLAm2TWThI+LqUB+QQJE3A3ph+rL46UHypWG0hw3LZ/P3I1geM3D0QNWZtNHHG0Rd p8Y8o7DVwoe2z0g2KvqOGKA2yVW0Ykhy+92/UEyZpfHe+xX8FyFqVSNB+jVYQF6XJ0k+ pUO3zGywLbJOYMfHRibW4vXXo7iW3beYOseIN/qgkOtwmZG7VXKs7K/noZuSBI89rA40 QBEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pSN9UAFB86h/tQZuVxtE7O47u5mZBXvhHQv7b1+5Vg4=; b=bLK+onghxkf69oJxFM7wFB6HGFJ+amO1RBQY5ANiL9EJCo56btoa8/gdYRCrf/rsne uNHIQ1F7j0Wlyywf6hWS+ztuoSH13z2J1JSbNEEawzUyn8GwQjfXsf2bFkBCzqdb+ZHX M/6JGm7Ol5ErAA9S211XIm6BPWjhG+RTu7Im0Kcc4lIw6Z1JiRBR1k70uaTD6ICbn5u1 jSdQdUcIXJ0r9vU+HjCLsQQvXQv2AaidNwenaVW3Lh1HK4CNwAL33cGwakDXuNbXZv+Z Vol6YAY9KSXZkIEwfxOaJWSegeygPfn+qwjDaZGkV+gUHLHSTRZoJbuV9JSEg8i678t0 lJXA== X-Gm-Message-State: AOAM533dh28wwafGTV/3gtzBLUk/Qy5Ny4k+Te1q4uwIHByfz1gC08lM 3n6mFIs5GQ21OkYXpWmnWpO/2seSbfcUgsCpS4Y= X-Google-Smtp-Source: ABdhPJzsGKT2sBRTn+qsy4ateXlNT+5sl9mQoQUajJ3SceYlz1T91KF0LvVWqyZj3zV55m/ed1J//LKVde75TXqpitM= X-Received: by 2002:a17:907:d09:: with SMTP id gn9mr3544063ejc.538.1616592102515; Wed, 24 Mar 2021 06:21:42 -0700 (PDT) MIME-Version: 1.0 References: <73298.1616563564@turing-police> In-Reply-To: <73298.1616563564@turing-police> From: Aruna Hewapathirane Date: Wed, 24 Mar 2021 09:21:31 -0400 Message-ID: Subject: Re: "Invalid signature" issue on dev kernel launch To: =?UTF-8?Q?Valdis_Kl=C4=93tnieks?= Cc: Gidi Gal , kernelnewbies X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2217583679894579229==" Errors-To: kernelnewbies-bounces@kernelnewbies.org --===============2217583679894579229== Content-Type: multipart/alternative; boundary="00000000000004690905be482e95" --00000000000004690905be482e95 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 24, 2021 at 1:26 AM Valdis Kl=C4=93tnieks wrote: > On Tue, 23 Mar 2021 22:36:33 -0400, Aruna Hewapathirane said: > > > I also see: > > CC drivers/cpufreq/cpufreq_ondemand.o > > drivers/cpufreq/cpufreq_ondemand.c: In function =E2=80=98od_set_powersa= ve_bias=E2=80=99: > > drivers/cpufreq/cpufreq_ondemand.c:446:1: warning: the frame size of 10= 32 > > bytes is larger than 1024 bytes [-Wframe-larger-than=3D] > > 446 | } > > | ^ > > This is what causes the compile time errors with possible missing > firmware > > No it's not. That's just a *warning* and doesn't stop the build. The > reason > that we have that warning is because on most architectures, the entire > kernel > stack has to fit into 2 contiguous 4k pages. > > Oh dear that's right it does not stop the build what was I thinking .. > And a perfectly legal stack can be something like TCP delivering an NFS > packet > which then goes to the NFS code, which then hands it off to the VFS layer= , > which checks the page cache, which hands it off to XFS, which schedules > I/O to > the filesystem, which gets handed to the block subsystem, which realizes > that > the target partition is an LVM partition, and LVM realizes that the > "physical > volume" is actually a dm-crypt, and then dm-crypt does some cryptography > and > calls the block subsystem to write to the physical disk. Feel free to > check the code > path yourself... :) > > Oh my... and oh dear ( again! ) > And all of that has to fit in 8K of stack. That's why we warn when things > have > a large stack frame entry. > I still don't understand why the 8K barrier ? Why can't we make it say 16K ? > > Anyhow, "possible missing firmware" isn't even at compile time - it's > during > the build of the initramfs at *install* time. And the most likely cause = of > that is that missing external firmware that's not GPL - it's all confined > to 2 > graphics drivers - amdgpu and i915, so not at all related to a warning > against > cpufreq... > > Understood and my apologies :-) --00000000000004690905be482e95 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Wed, Mar 24, 2021 at 1:26 AM Valdis Kl= =C4=93tnieks <valdis.kletniek= s@vt.edu> wrote:
On Tue, 23 Mar 2021 22:36:33 -0400, Aruna Hewapathirane said:

> I also see:
> CC=C2=A0 =C2=A0 =C2=A0 drivers/cpufreq/cpufreq_ondemand.o
> drivers/cpufreq/cpufreq_ondemand.c: In function =E2=80=98od_set_powers= ave_bias=E2=80=99:
> drivers/cpufreq/cpufreq_ondemand.c:446:1: warning: the frame size of 1= 032
> bytes is larger than 1024 bytes [-Wframe-larger-than=3D]
>=C2=A0 =C2=A0446 | }
>=C2=A0 =C2=A0 =C2=A0 =C2=A0| ^
> This is what causes the compile time errors with possible missing firm= ware

No it's not. That's just a *warning* and doesn't stop the build= .=C2=A0 The reason
that we have that warning is because on most architectures, the entire kern= el
stack has to fit into 2 contiguous 4k pages.

Oh dear that's right it does not stop the build w= hat was I thinking ..=C2=A0
=C2=A0
And a perfectly legal stack can be something like TCP delivering an NFS pac= ket
which then goes to the NFS code, which then hands it off to the VFS layer,<= br> which checks the page cache, which hands it off to XFS, which schedules I/O= to
the filesystem, which gets handed to the block subsystem, which realizes th= at
the target partition is an LVM partition, and LVM realizes that the "p= hysical
volume" is actually a dm-crypt, and then dm-crypt does some cryptograp= hy and
calls the block subsystem to write to the physical disk. Feel free to check= the code
path yourself... :)


Oh my... and oh dear ( again! )
=C2=A0
And all of that has to fit in 8K of stack. That's why we warn when thin= gs have
a large stack frame entry.

I still don&= #39;t understand why the 8K barrier ? Why can't we make it say 16K ?=C2= =A0

Anyhow, "possible missing firmware" isn't even at compile tim= e - it's during
the build of the initramfs at *install* time.=C2=A0 And the most likely cau= se of
that is that missing external firmware that's not GPL - it's all co= nfined to 2
graphics drivers - amdgpu and i915, so not at all related to a warning agai= nst
cpufreq...

Understood and my apologies :-)

=C2=A0
--00000000000004690905be482e95-- --===============2217583679894579229== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies --===============2217583679894579229==--