From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6BBFC282DB for ; Mon, 21 Jan 2019 10:11:14 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57B612085A for ; Mon, 21 Jan 2019 10:11:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GUlBbR6l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57B612085A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.91) (envelope-from ) id 1glWXX-00007e-Io; Mon, 21 Jan 2019 05:10:47 -0500 Received: from mail-oi1-x22c.google.com ([2607:f8b0:4864:20::22c]) by shelob.surriel.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1glWXU-00007Y-K4 for kernelnewbies@kernelnewbies.org; Mon, 21 Jan 2019 05:10:44 -0500 Received: by mail-oi1-x22c.google.com with SMTP id u18so14065920oie.10 for ; Mon, 21 Jan 2019 02:10:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=sBgJ3jxJcZgk9XvtEOw+OLO7qrBNE6HtxN4JMoesrL0=; b=GUlBbR6lRNmwepdR5Ai22zeSNsDmL4YXsqz+MK3aJ4khVlDVgk3asy0A4+zMvzLk+W 7iyDRl2oR5cF6purs2RHG5FSQKEKv9u/icKK2k1TzpXiI/bbAUEZHqReTKd1xPa/+t0k qBGWDEKAGV/HyvWJvekXi/Bye/Fa3Gj6+9kB/vlZPr2YnN8S+t8mpSOIuCfuvH4zGUFr ClAQN5Sm7vIMvybdSjLdbI0qNNgcD5u7/IGXUvyMDGgyIORenUMmdfr11afdh14M9yoR rYX7FUwydH4rY89r66lK23dCTCvYZNqK5Yam2fzgmhFi2eHzJvJ8xw/u6+0o0RUpjYoC SQNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=sBgJ3jxJcZgk9XvtEOw+OLO7qrBNE6HtxN4JMoesrL0=; b=hn9E8SueQR7hPdL+BrgcqiCJuptnFJKu3NR4BXpsVVZlGrAtRo+DA/GOUlN1/m4Mc+ oW338fIG8RbopRDCBzzDHRphAcTS8OEY3jv4ZrRef+XLEi8/4OThIfkikQ8H5teUmaWh eDBf3uFHQ+UjEJR4IzIwkIpxkQWIiGMazVWAu9/PJ4O/GzP8CEG4kZNuSBHElTrplvwX Nvmlo7sfesTxkIKmSUJ4fMpVQv+R4f7kqphgd7oU/tdEozssXDedI30TUCuMZKLiCxXL ChywGKZUDC0JRPcVKab+YpFHAnGfVK3cD4WO+MqmGGQgQnaancine7LRHtpyGk79hRhb kBQw== X-Gm-Message-State: AJcUukdCXbf+fW2fpPFblzJjEy2ECH3TJ7IY459TpocsmRrnN6j5fo1N R7tWHCkK0RzfmsmwfW6labNO+9AX6NjFvdpS3hSqj/Zr X-Google-Smtp-Source: ALg8bN7e8rZCl9YiaTcRApZXV0eLvoq6FvXE0P4kLnQvRBdzKnOH3N8QMjYL0PMKoZAnqIYuFBjzsDoNo4hpBH9syEE= X-Received: by 2002:a05:6808:282:: with SMTP id z2mr5457579oic.128.1548065442657; Mon, 21 Jan 2019 02:10:42 -0800 (PST) MIME-Version: 1.0 From: Muni Sekhar Date: Mon, 21 Jan 2019 15:40:31 +0530 Message-ID: Subject: drivers/char/efirtc.c - efi_rtc_open\ efi_rtc_close To: kernelnewbies Cc: Greg KH , arnd@arndb.de X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7129265842550504831==" Errors-To: kernelnewbies-bounces@kernelnewbies.org --===============7129265842550504831== Content-Type: multipart/alternative; boundary="000000000000cc788e057ff51218" --000000000000cc788e057ff51218 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello All, The drivers/char/efirtc.c file has =E2=80=98struct file_operations.open=E2= =80=99 & =E2=80=98struct file_operations.close=E2=80=99 functions efi_rtc_open()\ efi_rtc_close() do= es nothing, just returns =E2=80=980=E2=80=99. So it accept multiple open files at the same time. If we don=E2=80=99t defi= ne these empty function, still driver accepts multiple open() calls at the same time, right? If so I=E2=80=99d like to know what is the advantage of keeping these funct= ion which does nothing instead of removing it from driver? --=20 Thanks, Sekhar --000000000000cc788e057ff51218 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello All,
=C2=A0
The drivers/cha= r/efirtc.c file has =E2=80=98struct file_operations.open=E2=80=99 & =E2= =80=98struct file_operations.close=E2=80=99 functions efi_rtc_open()\ efi_r= tc_close() does nothing, just returns =E2=80=980=E2=80=99.
=C2=A0=
So it accept multiple open files at the same time. If we don=E2= =80=99t define these empty function, still driver accepts multiple open() c= alls at the same time, right?
=C2=A0
If so I=E2=80=99d = like to know what is the advantage of keeping these function which does not= hing instead of removing it from driver?


-- <= br>
Thanks,
Sekhar
--000000000000cc788e057ff51218-- --===============7129265842550504831== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies --===============7129265842550504831==--