Kernel Newbies archive on lore.kernel.org
 help / color / Atom feed
* Checkpatch.pl FAIL: "Blob or Tree named 'other' not found"
@ 2019-05-12  6:15 Deepak Mishra
  2019-05-12  7:41 ` Valdis Klētnieks
  0 siblings, 1 reply; 3+ messages in thread
From: Deepak Mishra @ 2019-05-12  6:15 UTC (permalink / raw)
  To: kernelnewbies

[-- Attachment #1.1: Type: text/plain, Size: 1157 bytes --]

Hi all,
I am trying to run checkpatch.pl on latest kernel version 5.1.0 source tree
from orig head 80f232121b69cc69a31ccb2b38c1665d770b0710

When I run checkpatch.pl, for every file I get the follwong or similar
error. Could you please help if this is my environment issue or actually
error in code which I need to fix ?

I executed the following in command prompt.
perl scripts/checkpatch.pl -f drivers/staging/rtl8712/* |less

The error I observe
drivers/staging/rtl8712/rtl871x_rf.h
------------------------------------
FAIL: "Blob or Tree named 'other' not found"
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 240, in <module>
    spdx = read_spdxdata(repo)
  File "scripts/spdxcheck.py", line 41, in read_spdxdata
    for el in lictree[d].traverse():
  File "/usr/lib/python2.7/dist-packages/git/objects/tree.py", line 298, in
__getitem__
    return self.join(item)
  File "/usr/lib/python2.7/dist-packages/git/objects/tree.py", line 244, in
join
    raise KeyError(msg % file)
KeyError: "Blob or Tree named 'other' not found"

total: 0 errors, 0 warnings, 0 checks, 56 lines checked

Please suggest me.

Best Regards
Mishradk

[-- Attachment #1.2: Type: text/html, Size: 1851 bytes --]

<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">Hi all,<div>I am trying to run <a href="http://checkpatch.pl">checkpatch.pl</a> on latest kernel version 5.1.0 source tree from orig head 80f232121b69cc69a31ccb2b38c1665d770b0710</div><div><br></div><div>When I run <a href="http://checkpatch.pl" target="_blank">checkpatch.pl</a>, for every file I get the follwong or similar error. Could you please help if this is my environment issue or actually error in code which I need to fix ?</div><div><br></div><div>I executed the following in command prompt.</div><div>perl scripts/<a href="http://checkpatch.pl" target="_blank">checkpatch.pl</a> -f drivers/staging/rtl8712/* |less<br></div><div><br></div><div>The error I observe </div><div><div>drivers/staging/rtl8712/rtl871x_rf.h</div><div>------------------------------------</div><div>FAIL: &quot;Blob or Tree named &#39;other&#39; not found&quot;</div><div>Traceback (most recent call last):</div><div>  File &quot;scripts/spdxcheck.py&quot;, line 240, in &lt;module&gt;</div><div>    spdx = read_spdxdata(repo)</div><div>  File &quot;scripts/spdxcheck.py&quot;, line 41, in read_spdxdata</div><div>    for el in lictree[d].traverse():</div><div>  File &quot;/usr/lib/python2.7/dist-packages/git/objects/tree.py&quot;, line 298, in __getitem__</div><div>    return self.join(item)</div><div>  File &quot;/usr/lib/python2.7/dist-packages/git/objects/tree.py&quot;, line 244, in join</div><div>    raise KeyError(msg % file)</div><div>KeyError: &quot;Blob or Tree named &#39;other&#39; not found&quot;</div><div><br></div><div>total: 0 errors, 0 warnings, 0 checks, 56 lines checked</div></div><div><br></div><div>Please suggest me.</div><div><br></div><div>Best Regards</div><div>Mishradk</div><div><br></div></div></div></div></div></div></div>

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Checkpatch.pl FAIL: "Blob or Tree named 'other' not found"
  2019-05-12  6:15 Checkpatch.pl FAIL: "Blob or Tree named 'other' not found" Deepak Mishra
@ 2019-05-12  7:41 ` Valdis Klētnieks
  2019-05-12  8:15   ` Deepak Mishra
  0 siblings, 1 reply; 3+ messages in thread
From: Valdis Klētnieks @ 2019-05-12  7:41 UTC (permalink / raw)
  To: Deepak Mishra; +Cc: kernelnewbies

On Sun, 12 May 2019 11:45:24 +0530, Deepak Mishra said:

> When I run checkpatch.pl, for every file I get the follwong or similar
> error. Could you please help if this is my environment issue or actually
> error in code which I need to fix ?
>
> I executed the following in command prompt.
> perl scripts/checkpatch.pl -f drivers/staging/rtl8712/* |less
>
> The error I observe
> drivers/staging/rtl8712/rtl871x_rf.h

Found the problem, patch submitted.  It's a one-line fix:

diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py
index 4fe392e507fb..7abd5f5cb14d 100755
--- a/scripts/spdxcheck.py
+++ b/scripts/spdxcheck.py
@@ -32,7 +32,7 @@ import os
 def read_spdxdata(repo):
 
     # The subdirectories of LICENSES in the kernel source
-    license_dirs = [ "preferred", "other", "exceptions" ]
+    license_dirs = [ "preferred", "dual", "deprecated", "exceptions" ]
     lictree = repo.head.commit.tree['LICENSES']





_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Checkpatch.pl FAIL: "Blob or Tree named 'other' not found"
  2019-05-12  7:41 ` Valdis Klētnieks
@ 2019-05-12  8:15   ` Deepak Mishra
  0 siblings, 0 replies; 3+ messages in thread
From: Deepak Mishra @ 2019-05-12  8:15 UTC (permalink / raw)
  To: Valdis Klētnieks; +Cc: kernelnewbies

[-- Attachment #1.1: Type: text/plain, Size: 1232 bytes --]

Thanks Valdis,
After applying the patch, I verified in my environment and the patch has
fixed the issue.

Best Regards
MishraDk

On Sun, May 12, 2019 at 1:12 PM Valdis Klētnieks <valdis.kletnieks@vt.edu>
wrote:

> On Sun, 12 May 2019 11:45:24 +0530, Deepak Mishra said:
>
> > When I run checkpatch.pl, for every file I get the follwong or similar
> > error. Could you please help if this is my environment issue or actually
> > error in code which I need to fix ?
> >
> > I executed the following in command prompt.
> > perl scripts/checkpatch.pl -f drivers/staging/rtl8712/* |less
> >
> > The error I observe
> > drivers/staging/rtl8712/rtl871x_rf.h
>
> Found the problem, patch submitted.  It's a one-line fix:
>
> diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py
> index 4fe392e507fb..7abd5f5cb14d 100755
> --- a/scripts/spdxcheck.py
> +++ b/scripts/spdxcheck.py
> @@ -32,7 +32,7 @@ import os
>  def read_spdxdata(repo):
>
>      # The subdirectories of LICENSES in the kernel source
> -    license_dirs = [ "preferred", "other", "exceptions" ]
> +    license_dirs = [ "preferred", "dual", "deprecated", "exceptions" ]
>      lictree = repo.head.commit.tree['LICENSES']
>
>
>
>
>

[-- Attachment #1.2: Type: text/html, Size: 1872 bytes --]

<div dir="ltr">Thanks Valdis,<div>After applying the patch, I verified in my environment and the patch has fixed the issue. </div><div><br></div><div>Best Regards</div><div>MishraDk</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, May 12, 2019 at 1:12 PM Valdis Klētnieks &lt;<a href="mailto:valdis.kletnieks@vt.edu">valdis.kletnieks@vt.edu</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Sun, 12 May 2019 11:45:24 +0530, Deepak Mishra said:<br>
<br>
&gt; When I run <a href="http://checkpatch.pl" rel="noreferrer" target="_blank">checkpatch.pl</a>, for every file I get the follwong or similar<br>
&gt; error. Could you please help if this is my environment issue or actually<br>
&gt; error in code which I need to fix ?<br>
&gt;<br>
&gt; I executed the following in command prompt.<br>
&gt; perl scripts/<a href="http://checkpatch.pl" rel="noreferrer" target="_blank">checkpatch.pl</a> -f drivers/staging/rtl8712/* |less<br>
&gt;<br>
&gt; The error I observe<br>
&gt; drivers/staging/rtl8712/rtl871x_rf.h<br>
<br>
Found the problem, patch submitted.  It&#39;s a one-line fix:<br>
<br>
diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py<br>
index 4fe392e507fb..7abd5f5cb14d 100755<br>
--- a/scripts/spdxcheck.py<br>
+++ b/scripts/spdxcheck.py<br>
@@ -32,7 +32,7 @@ import os<br>
 def read_spdxdata(repo):<br>
<br>
     # The subdirectories of LICENSES in the kernel source<br>
-    license_dirs = [ &quot;preferred&quot;, &quot;other&quot;, &quot;exceptions&quot; ]<br>
+    license_dirs = [ &quot;preferred&quot;, &quot;dual&quot;, &quot;deprecated&quot;, &quot;exceptions&quot; ]<br>
     lictree = repo.head.commit.tree[&#39;LICENSES&#39;]<br>
<br>
<br>
<br>
<br>
</blockquote></div>

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-12  6:15 Checkpatch.pl FAIL: "Blob or Tree named 'other' not found" Deepak Mishra
2019-05-12  7:41 ` Valdis Klētnieks
2019-05-12  8:15   ` Deepak Mishra

Kernel Newbies archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kernelnewbies/0 kernelnewbies/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kernelnewbies kernelnewbies/ https://lore.kernel.org/kernelnewbies \
		kernelnewbies@kernelnewbies.org kernelnewbies@archiver.kernel.org
	public-inbox-index kernelnewbies


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernelnewbies.kernelnewbies


AGPL code for this site: git clone https://public-inbox.org/ public-inbox