From: jim.cromie@gmail.com
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: kernelnewbies <kernelnewbies@kernelnewbies.org>
Subject: Re: replacing if-then-else strcmp ladders with switch cases
Date: Sat, 13 Jun 2020 11:08:14 -0600 [thread overview]
Message-ID: <CAJfuBxwmaOo7Jn4ostbv3_9yqcF_AFjO+L=vwnMOEUvbj29sAg@mail.gmail.com> (raw)
In-Reply-To: <329015.1592024536@turing-police>
On Fri, Jun 12, 2020 at 11:02 PM Valdis Klētnieks
<valdis.kletnieks@vt.edu> wrote:
>
> On Fri, 12 Jun 2020 12:05:55 -0600, jim.cromie@gmail.com said:
> > considering lib/dynamic_debug.c
> > we have
> >
> > ...
> > } else if (!strcmp(words[i], "module")) {
> > rc = check_set(&query->module, words[i+1], "module");
> > } else if (!strcmp(words[i], "format")) {
> > ...
> >
> > are there any built-in hash functions which would allow this ?
> >
> > switch (keyword) {
> > case Hash("module"):
> > ..... break;
that should be:
/* 2 compatible implementations */
#define chash(keywd) simple_hash_computed_by_compiler ( keywd )
#define rhash(keywd) simple_hash_computed_at_runtime ( keywd )
switch ( rhash (keyword) ) {
case chash("module"):
... break;
> There's hash functions. But they're all cryptographic hashes that return
> things that are far too many bits to use as the index of a switch.
>
> Also, you have the problem that the cases of a switch have to be something
> that can be evaluated at compile time....
ok, so they dont exist.
I suspect its doable, but needs big -fu, more than I got
that said, I could imagine a compile-time check to insure that
the simple-hash on a fixed dictionary yields no collision
DEFINE_DICTIONARY( "dyndbg.control.adverbs", "module", "file", "line", "func" )
but thats not essential, since if theyre in case:s,
the compiler would notice the collision,
and so chash() doesnt need to do collision detection either.
this would be slick, and I think usable more than once.
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
prev parent reply other threads:[~2020-06-13 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 18:05 replacing if-then-else strcmp ladders with switch cases jim.cromie
2020-06-13 5:02 ` Valdis Klētnieks
2020-06-13 17:08 ` jim.cromie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfuBxwmaOo7Jn4ostbv3_9yqcF_AFjO+L=vwnMOEUvbj29sAg@mail.gmail.com' \
--to=jim.cromie@gmail.com \
--cc=kernelnewbies@kernelnewbies.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).