From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF47C433C1 for ; Sun, 21 Mar 2021 16:25:53 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5946D61934 for ; Sun, 21 Mar 2021 16:25:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5946D61934 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94) (envelope-from ) id 1lO0tW-0007TI-8G; Sun, 21 Mar 2021 12:25:38 -0400 Received: from mail-ot1-x334.google.com ([2607:f8b0:4864:20::334]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lO0tV-0007T9-8V for kernelnewbies@kernelnewbies.org; Sun, 21 Mar 2021 12:25:37 -0400 Received: by mail-ot1-x334.google.com with SMTP id m21-20020a9d7ad50000b02901b83efc84a0so13538315otn.10 for ; Sun, 21 Mar 2021 09:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=swu4lAIifdDb0rwfi3KCM9IK9Uh+EBj1o9v38nlumbY=; b=mk09na3mam+2g4JLQeJNSm8Y1DVc0hsR31/9lij7tcfQeYqpYOLxzFXYtnts+hKQ1t rs8ukEYeSp37a+wRj+x9FPsydtRMm5lkK8ULGo9z48LRR/Oq/Gr1alosRRkjzLbQEQse 3hK1iXo2yI1FIXJ31/tnORRe6g7TeOPYnLmW6xgMQ5TvPNsVbeOttG+i4tm8r47LMgG5 pA3jBg5fP0qYsi8CHCZ1zPITKTIHNa1o0ZCzBZCXh7ZN7Jm0NJFUkBp0j1SaRU4z5MaU PVYITF9/nSfpynobzKA1mutM3Gy43Si2vytt8BsL3DDx56UuY5VCROfa/+w7sipKB5Il UBUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=swu4lAIifdDb0rwfi3KCM9IK9Uh+EBj1o9v38nlumbY=; b=Hx6DjbePouyw1ys771I8P/wz7cStqABfkTQPlAVWf7uTKzSYjcbFNznApVtM9Uuv7R V1swxgPv8D/WoX2GbVgLOgqWmTZwo/+bqTctTl6pRpOGOvbCWp9IMhbgH8wDxuWgBiZW IQg2KLVb3YDOnqJTBxDwDaVvVpFS1OqswkWeh/GXr8SoTLhezQqhElmJMMJ2c/fkr8cf 9dfRmV/gNpsuyodBT00Tm3mC6+TSwSc39jU06JEYL4vk+cNqnVdD4bkPV9NLJMKN16Dl 0VeCmXIovneq7QDXurfWH9sHKLmdTWLmG7BUjmOZiKcARyEhsekaj1UEOWJzcVpnp0Ze 6XKQ== X-Gm-Message-State: AOAM530lzZtQdKlpIzit3OEO7DyUew/KheHOcCvlyrd1EkOZS+eNVDfM HITW3bpQIcXICY1ASvd19MOfKm/j9OKzCq99QBFQxY19Y6g= X-Google-Smtp-Source: ABdhPJzSXl7iZexeerOCK4TAw/OFS6+l3qbteh6FYPel6zWZo9Fk0Hl4Rx+fuRcmGf7h2yLhy1Y8kuPm3aCZ8fAL0Aw= X-Received: by 2002:a9d:7a87:: with SMTP id l7mr774394otn.367.1616343935828; Sun, 21 Mar 2021 09:25:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Harsha Vardhan Date: Sun, 21 Mar 2021 12:25:24 -0400 Message-ID: Subject: Re: picking the first patch To: Greg KH Cc: kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============9077847874750713190==" Errors-To: kernelnewbies-bounces@kernelnewbies.org --===============9077847874750713190== Content-Type: multipart/alternative; boundary="00000000000021467705be0e6614" --00000000000021467705be0e6614 Content-Type: text/plain; charset="UTF-8" perfect ! I will do it that way then. besides that, generally if you are making changes to drivers , then the responsibility of testing is on the author of the patch right ? if you don't have the device how would you test such things ? I would assume other subsystems like memory will have some sort of test suite that gets run automatically to make sure we are not introducing any regressions but confused as to how we ensure the same with drivers. Thanks so much Greg , for a quick reply . On Sun, Mar 21, 2021 at 12:14 PM Greg KH wrote: > On Sun, Mar 21, 2021 at 12:03:36PM -0400, Harsha Vardhan wrote: > > Any thoughts on whether I should just do a checkpatch.pl change as my > first > > patch ? > > You should do a checkpatch.pl change as your first patch :) > > That way you can focus on the process more than the technical aspects of > the patch (git, changelog text, subject line, email, submission, > revision, acceptance, etc.) and not have to worry a lot about breaking > working code or not. > > After you get the process working properly for you, then move to > changing real code and contributing that way. > > But that's just a suggestion, not a requirement, you can do whatever you > want to do :) > > good luck! > > greg k-h > --00000000000021467705be0e6614 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
perfect ! I will do it that way then.

besides that, generally if you are making changes to drivers , then the= responsibility of testing is on the author of the patch right ? if you don= 't have the device how would you test such things ?=C2=A0 I would assum= e other subsystems like memory will have some sort of test suite that gets = run automatically to make sure we are not introducing any regressions but c= onfused as to how we ensure the same with drivers.

Thanks so = much Greg , for a quick reply .

On Sun, Mar 21, 2021 at 12:14 PM Greg KH= <greg@kroah.com> wrote:
On Sun, Mar 21, 2021 a= t 12:03:36PM -0400, Harsha Vardhan wrote:
> Any thoughts on whether I should just do a checkpatch.pl change as my f= irst
> patch ?

You should do a checkpatch.pl change as your first patch :)

That way you can focus on the process more than the technical aspects of the patch (git, changelog text, subject line, email, submission,
revision, acceptance, etc.) and not have to worry a lot about breaking
working code or not.

After you get the process working properly for you, then move to
changing real code and contributing that way.

But that's just a suggestion, not a requirement, you can do whatever yo= u
want to do :)

good luck!

greg k-h
--00000000000021467705be0e6614-- --===============9077847874750713190== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies --===============9077847874750713190==--